Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Prevent generating cmdline_test.py in vcompressor benchmark #280

Merged
merged 1 commit into from
Sep 9, 2022
Merged

FIX: Prevent generating cmdline_test.py in vcompressor benchmark #280

merged 1 commit into from
Sep 9, 2022

Conversation

Sefank
Copy link
Contributor

@Sefank Sefank commented Sep 9, 2022

I've forgotten cleanup code in #268 so that after benchmark is conducted, there is a cmdline_test.py left. Sorry for that :D
This commit should fix it.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (trace-log-compressor@5fc5b45). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             trace-log-compressor     #280   +/-   ##
=======================================================
  Coverage                        ?   99.77%           
=======================================================
  Files                           ?       21           
  Lines                           ?     2205           
  Branches                        ?        0           
=======================================================
  Hits                            ?     2200           
  Misses                          ?        5           
  Partials                        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tests/test_vcompressor.py Outdated Show resolved Hide resolved
@Sefank Sefank changed the title FIX: Cleanup after vcompressor benchmark FIX: Prevent generating cmdline_test.py in vcompressor benchmark Sep 9, 2022
@Sefank Sefank changed the title FIX: Prevent generating cmdline_test.py in vcompressor benchmark FIX: Prevent generating cmdline_test.py in vcompressor benchmark Sep 9, 2022
@Sefank Sefank marked this pull request as draft September 9, 2022 04:10
@Sefank Sefank marked this pull request as ready for review September 9, 2022 04:29
@gaogaotiantian gaogaotiantian merged commit 1db2799 into gaogaotiantian:trace-log-compressor Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants