Fix off-by-one bug and cleanup GL calls #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collenjones
changed the title
collenjones
commented
Jul 18, 2020
Comment on lines
-43
to
-44
| glEnable(GL_BLEND); | ||
| glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); |
There was a problem hiding this comment.
We do not need alpha blending in this example
collenjones
commented
Jul 18, 2020
Comment on lines
+53
to
+54
| glClearColor(1.0f, 1.0f, 1.0f, 1.0f); | ||
| glLineWidth(2); |
There was a problem hiding this comment.
These do not change so we don't need to reset them every loop iteration
collenjones
commented
Jul 18, 2020
| @@ -76,7 +74,7 @@ void DrawTrajectory(vector<Isometry3d, Eigen::aligned_allocator<Isometry3d>> pos | |||
| glEnd(); | |||
| } | |||
| // 画出连线 | |||
| for (size_t i = 0; i < poses.size(); i++) { | |||
There was a problem hiding this comment.
Off by one error here since we're drawing a line from i -> i + 1
collenjones
commented
Jul 18, 2020
| glClearColor(1.0f, 1.0f, 1.0f, 1.0f); | ||
| glLineWidth(2); | ||
| for (size_t i = 0; i < poses.size(); i++) { | ||
| for (size_t i = 0; i < poses.size(); ++i) { |
There was a problem hiding this comment.
nit: ++i is more efficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
++iinstead ofi++to remove temporary variable creation