Some feedback (DO NOT MERGE) #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,6 +273,7 @@ InstallGlobalFunction(LINS_FindPModules, function(gr, rH, p, opts) | |||
| IH := Image(Iso); | |||
|
|
|||
| # Create the Isomorphism to the group structure of the `p`-Module `M` | |||
| # TODO: have you considered using anupq here instead of PQuotient? | |||
There was a problem hiding this comment.
No I haven't considered it. Didn't know it existed. Thanks for the hint :)
| @@ -46,7 +46,7 @@ end); | |||
| ## returns the size of the group $GL(s, p)$. | |||
| ############################################################################# | |||
|
|
|||
| BindGlobal("LINS_OGL", function(s, p) | |||
| BindGlobal("LINS_OGL", function(s, p) # TODO: could use GAP function SizeGL instead (it is not listed in the reference manual; maybe it should be...) | |||
| @@ -113,6 +113,7 @@ InstallGlobalFunction(LINS_MustCheckP, function(rH, n, p) | |||
| od; | |||
|
|
|||
| # maximal integer $s$ such that $[G : H] * p ^ s <= n$ | |||
| # TODO: isn't this just `s := LogInt(n/index, p);` ? | |||
There was a problem hiding this comment.
Yes, but my brain stopped working at this line of code 🤦
fingolfin
commented
Jun 7, 2023
| @@ -412,6 +414,9 @@ InstallGlobalFunction(LINS_FindPQuotients, function(gr, rH, primes, opts) | |||
| if p > n / Index(rH) then | |||
| break; | |||
| fi; | |||
| # TODO: note that group Q will have a non-trivial p-quotient | |||
| # iff 0 or p is in AbelianInvariants(Q) | |||
There was a problem hiding this comment.
This is not quite right, as also a power of p might be in the AbelianInvariants`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.