Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused by LINS_MaxPGenerators being too low. #67

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions gap/findPQuotients.gi
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,6 @@ BindGlobal("LINS_PullBackH", function(GenM, p, Gens, O, Mu, Psi)
end);


#############################################################################
## maximal generators of a p-quotient.
#############################################################################

BindGlobal("LINS_MaxPGenerators", 1000);


#############################################################################
## LINS_FindPModules
#############################################################################
Expand Down Expand Up @@ -225,6 +218,8 @@ InstallGlobalFunction(LINS_FindPModules, function(gr, rH, p, opts)
n, # pos-int: index bound of LINS graph `gr`.
Iso, # isomorphism: from `H` into fp-group
IH, # fp-group: image under `Iso`, isomorphic to `H`
logord, # int: option for PQuotient, the maximal order
# for P we consider is p^logord
P, # quotsys: p-quotient of `IH` of class 1
Mu, # epimorphism: from `IH` into `P`
M, # pc-group: image under `Mu`
Expand Down Expand Up @@ -272,7 +267,8 @@ InstallGlobalFunction(LINS_FindPModules, function(gr, rH, p, opts)
IH := Image(Iso);

# Create the Isomorphism to the group structure of the `p`-Module `M`
P := PQuotient(IH, p, 1, LINS_MaxPGenerators);
logord := Int(Log(Float(n / rH!.Index))/Log(Float(p)));
P := PQuotient(IH, p, 1, logord);
Mu := EpimorphismQuotientSystem(P);
M := Image(Mu);
GenM := GeneratorsOfGroup(M);
Expand Down
Loading