Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'debug' option which preserves failed package dirs #119

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

fingolfin
Copy link
Member

If a package fails to install, it is normally deleted to prevent stale
packages from clogging up the system. But for debugging the failure it
is useful to keep the package around.

If a package fails to install, it is normally deleted to prevent stale
packages from clogging up the system. But for debugging the failure it
is useful to keep the package around.
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #119 (c868686) into master (4d8e91f) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files           4        4           
  Lines        1020     1032   +12     
=======================================
+ Hits          849      859   +10     
- Misses        171      173    +2     
Files Changed Coverage Δ
gap/PackageManager.gi 81.91% <83.33%> (+0.01%) ⬆️

@james-d-mitchell
Copy link
Contributor

I think this is a great idea!

@fingolfin
Copy link
Member Author

Note that I did not add the check to the PKGMAN_RemoveDir call in RemovePackage because that's a core part of the functionality of RemovePackage -- we really want it to remove the package.

@fingolfin fingolfin marked this pull request as ready for review August 21, 2023 09:25
@fingolfin fingolfin merged commit d69e567 into gap-packages:master Aug 29, 2023
5 checks passed
@fingolfin fingolfin deleted the mh/debug branch August 29, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants