Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admit switching off interactive mode #125

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ThomasBreuer
Copy link
Contributor

pass on the interactive flag from InstallPackage also to InstallPackageFromGit and InstallPackageFromHg, not only to InstallPackageFromName

pass on the `interactive` flag from `InstallPackage`
also to `InstallPackageFromGit` and `InstallPackageFromHg`,
not only to `InstallPackageFromName`
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (cf58d17) to head (ff3305c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   82.94%   82.56%   -0.39%     
==========================================
  Files           4        4              
  Lines        1038     1038              
==========================================
- Hits          861      857       -4     
- Misses        177      181       +4     
Files Coverage Δ
gap/PackageManager.gi 81.15% <100.00%> (-0.42%) ⬇️

Copy link
Contributor

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mtorpey
Copy link
Collaborator

mtorpey commented Jun 19, 2024

Perfect, Thank you!

@mtorpey mtorpey merged commit 79002e6 into gap-packages:master Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants