InstallValue on types leads to incorrect behavior

So don't do it, see gap-system/gap#1637 Also remove some unused families.
gap-packages · Mar 8, 2024 · 55f7cb9 · 55f7cb9
1 parent f8604b8
commit 55f7cb9
Show file tree

Hide file tree

Showing 15 changed files with 5 additions and 19 deletions.
diff --git a/lib/brace.gd b/lib/brace.gd
@@ -1,5 +1,4 @@
 DeclareCategory("IsBrace", IsAttributeStoringRep);
-DeclareGlobalVariable("BraceType");
 
 ### To create/recognize braces 
 DeclareOperation("Brace", [IsList]);

diff --git a/lib/brace.gi b/lib/brace.gi
@@ -1,6 +1,6 @@
 ### braces
 BindGlobal("BraceFamily", NewFamily("BraceFamily"));
-InstallValue(BraceType, NewType(BraceFamily, IsBrace));
+BindGlobal("BraceType", NewType(BraceFamily, IsBrace));
 
 InstallMethod(Brace, "for a list of pairs of elements in a group", [IsList], 
 function(p)

diff --git a/lib/cycleset.gd b/lib/cycleset.gd
@@ -4,7 +4,6 @@ DeclareCategory("IsCycleSetElm", IsMultiplicativeElement);
 DeclareRepresentation( "IsCycleSetElmRep", IsPositionalObjectRep, [ 1 ]);
 DeclareOperation("CycleSetElmConstructor", [IsCycleSet, IsInt]);
 
-#DeclareGlobalVariable("CycleSetType");
 BindGlobal("CycleSetElmFamily", NewFamily("CycleSetElmFamily", IsCycleSetElm));
 BindGlobal("CycleSetElmType", NewType(CycleSetElmFamily, IsCycleSetElm));
 BindGlobal("CycleSetType", NewType(CollectionsFamily( CycleSetElmFamily ), IsCycleSet and IsAttributeStoringRep));

diff --git a/lib/cycleset.gi b/lib/cycleset.gi
@@ -1,6 +1,4 @@
 ### cycle sets
-BindGlobal("CycleSetFamily", NewFamily("CycleSetFamily"));
-#InstallValue(CycleSetType, NewType(CycleSetFamily, IsCycleSet));
 
 ### This function returns the cycle set associated with the action given <matrix>
 InstallMethod(CycleSet, "for a matrix", [IsList],

diff --git a/lib/linear.gd b/lib/linear.gd
@@ -1,5 +1,4 @@
 DeclareCategory("IsLinearCycleSet", IsAttributeStoringRep);
-DeclareGlobalVariable("LinearCycleSetType");
 
 ### To create/recognize braces 
 DeclareOperation("LinearCycleSet", [IsList, IsMatrix]);

diff --git a/lib/linear.gi b/lib/linear.gi
@@ -1,6 +1,6 @@
 ### linear cycle sets
 BindGlobal("LinearCycleSetFamily", NewFamily("LinearCycleSetFamily"));
-InstallValue(LinearCycleSetType, NewType(LinearCycleSetFamily, IsLinearCycleSet));
+BindGlobal("LinearCycleSetType", NewType(LinearCycleSetFamily, IsLinearCycleSet));
 
 InstallMethod(LinearCycleSet, "for the list of elements of a group and a matrix", [IsList, IsMatrix], 
 function(l, m)

diff --git a/lib/qlinear.gd b/lib/qlinear.gd
@@ -1,5 +1,4 @@
 DeclareCategory("IsQLCycleSet", IsAttributeStoringRep);
-DeclareGlobalVariable("QLCycleSetType");
 
 DeclareOperation("QLCycleSet", [IsList, IsMatrix]);
 DeclareOperation("SmallQLCycleSet", [IsInt, IsInt]);

diff --git a/lib/qlinear.gi b/lib/qlinear.gi
@@ -1,6 +1,6 @@
 ### quasilinear cycle sets
 BindGlobal("QLCycleSetFamily", NewFamily("QLCycleSetFamily"));
-InstallValue(QLCycleSetType, NewType(QLCycleSetFamily, IsQLCycleSet));
+BindGlobal("QLCycleSetType", NewType(QLCycleSetFamily, IsQLCycleSet));
 
 InstallMethod(QLCycleSet, "for the list of elements of a group and a matrix", [IsList, IsMatrix], 
 function(l, m)

diff --git a/lib/rack.gd b/lib/rack.gd
@@ -8,8 +8,6 @@ BindGlobal("RackElmFamily", NewFamily("RackElmFamily", IsRackElm));
 BindGlobal("RackElmType", NewType(RackElmFamily, IsRackElm));
 BindGlobal("RackType", NewType(CollectionsFamily( RackElmFamily ), IsRack and IsAttributeStoringRep));
 
-#DeclareGlobalVariable("RackType");
-
 ### To create/recognize racks 
 DeclareOperation("Rack", [IsList]);
 DeclareAttribute("Rack2YB", IsRack);

diff --git a/lib/rack.gi b/lib/rack.gi
@@ -1,6 +1,4 @@
 ### racks
-BindGlobal("RackFamily", NewFamily("RackFamily"));
-#InstallValue(RackType, NewType(RackFamily, IsRack));
 
 InstallMethod(Rack, "for a matrix", [ IsMatrix ], 
 function(matrix)

diff --git a/lib/skew.gi b/lib/skew.gi
@@ -1,6 +1,4 @@
 ### skew braces
-BindGlobal("SkewbraceFamily", NewFamily("SkewbraceFamily"));
-#InstallValue(SkewbraceType, NewType(SkewbraceFamily, IsSkewbrace));
 
 InstallMethod(Skewbrace, "for a list of pairs of elements in a group", [IsList], 
 function(p)

diff --git a/lib/tau.gd b/lib/tau.gd
@@ -1,5 +1,4 @@
 DeclareCategory("IsTauGroup", IsAttributeStoringRep);
-DeclareGlobalVariable("TauGroupType");
 
 DeclareOperation("TauGroup", [IsList, IsPerm]);
 DeclareOperation("SmallTauGroup", [IsInt, IsInt]);

diff --git a/lib/tau.gi b/lib/tau.gi
@@ -1,6 +1,6 @@
 ### quasilinear cycle sets
 BindGlobal("TauGroupFamily", NewFamily("TauGroupFamily"));
-InstallValue(TauGroupType, NewType(TauGroupFamily, IsTauGroup));
+BindGlobal("TauGroupType", NewType(TauGroupFamily, IsTauGroup));
 
 InstallMethod(TauGroup, "for the list of elements of a group and a permutation", [IsList, IsPerm], 
 function(l, p)

diff --git a/lib/ybe.gd b/lib/ybe.gd
@@ -2,7 +2,6 @@
 #! @Section Braces and Yang-Baxter Equation
 
 DeclareCategory("IsYB", IsAttributeStoringRep);
-DeclareGlobalVariable("YBType");
 
 DeclareOperation("SmallIYB", [IsInt, IsInt]);
 DeclareOperation("YB", [IsList, IsList]);

diff --git a/lib/ybe.gi b/lib/ybe.gi
@@ -1,5 +1,5 @@
 BindGlobal("YBFamily", NewFamily("YBFamily"));
-InstallValue(YBType, NewType(YBFamily, IsYB));
+BindGlobal("YBType", NewType(YBFamily, IsYB));
 
 ### This function returns the set-theoretic solution given by the permutations <l_actions> and <r_actions>
 ### <l_action> and <r_action> are matrices!