Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test with GAP 4.13; test with mininimal set of packages loaded #97

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

fingolfin
Copy link
Member

Unfortunately I expect that this will fail -- because it already
is failing on the PackageDistro tests. But we will see.

@vendramin vendramin merged commit 6c9d8bd into master Mar 24, 2024
1 of 7 checks passed
@vendramin vendramin deleted the mh/CI branch March 24, 2024 17:23
@fingolfin
Copy link
Member Author

@vendramin just to double check: you saw that all tests fail with this merged?

@olexandr-konovalov
Copy link
Member

@fingolfin ah, I see - so that's why yesterday tests were passing here, but not in PackageDistro. I think now, since it's merged, we are in sync, and can work on improving the tests in this repository.

@olexandr-konovalov
Copy link
Member

@vendramin this is what @fingolfin refers to: gap-system/PackageDistro#932

@vendramin
Copy link
Collaborator

vendramin commented Mar 24, 2024 via email

@olexandr-konovalov
Copy link
Member

olexandr-konovalov commented Mar 24, 2024

The testing of the package distro became more thorough, since it tests now also if the package runs with only required packages, omitting suggested ones. Now @fingolfin updated testing setup in this repository, so we should be able to run the same testing steps from now on. From https://github.com/gap-packages/YangBaxter/actions/runs/8410957154/job/23029997126#step:6:323 it looks like there is nothing serious, just some outputs are in different order, so it should be easy to fix, and that will help to make tests more robust in case of future randomness fluctuations.

@fingolfin
Copy link
Member Author

To be clear, the PackageDistro always performed these tests. This PR just makes sure you run the same tests here, to make sure issues like these (which seem to be recent?) are discovered by you guys earlier

@fingolfin
Copy link
Member Author

The failures seem to (mostly?) come from 069c0d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants