Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Travis & Codecov setup #18

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Conversation

fingolfin
Copy link
Member

For Codecov, actually enable status messages in pull requests (so far,
all were turned off, but for some reason codecov ignores this; still,
better to specify actual intent in the file).

For Travis, adapt scripts/build_pkg.sh to work with packages not using
autoconf, so that we can use the same script across many packages. Also
don't copy the tested package into GAP's pkg dir; instead, put it into
its own GAP root which we tell GAP to look at before its usual GAP root.

Modify scripts/gather-coverage.sh and scripts/run_tests.sh to use this
modified list of GAP root dirs

Simplify scripts/build_gap.sh significantly by using BuildPackages.sh.

@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   35.62%   35.62%           
=======================================
  Files           2        2           
  Lines         379      379           
  Branches       67       69    +2     
=======================================
  Hits          135      135           
  Misses        222      222           
  Partials       22       22

@fingolfin fingolfin force-pushed the mh/travis branch 3 times, most recently from 41b3c89 to bfca956 Compare December 14, 2017 14:53
@fingolfin
Copy link
Member Author

Hmm, it seems the Travis builds are failing on master, so of course they are failing for this PR, too. The test suite is somehow segfaulting, hum.

Failures started when Use C99 init for StructInitInfo was merged, but the tests for that PR did work. That seems fishy.

Perhaps the problem is caused by Travis having updated some software, e.g. perhaps their zeromq is now a different version? Should be possible to tell by inspecting and comparing the travis build logs.

@fingolfin fingolfin force-pushed the mh/travis branch 4 times, most recently from 38aad5d to eb9322e Compare December 17, 2017 22:51
For Codecov, actually enable status messages in pull requests (so far,
all were turned off, but for some reason codecov ignores this; still,
better to specify actual intent in the file).

For Travis, adapt scripts/build_pkg.sh to work with packages not using
autoconf, so that we can use the same script across many packages. Also
don't copy the tested package into GAP's pkg dir; instead, put it into
its own GAP root which we tell GAP to look at before its usual GAP root.

Modify scripts/gather-coverage.sh and scripts/run_tests.sh to use this
modified list of GAP root dirs

Simplify scripts/build_gap.sh significantly by using BuildPackages.sh.
@fingolfin
Copy link
Member Author

I fixed the build failures on the master branch, now tests pass here, too.

@markuspf markuspf merged commit 976a6a9 into gap-packages:master Dec 18, 2017
@fingolfin fingolfin deleted the mh/travis branch February 16, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants