Skip to content

Commit

Permalink
Add a bunch of trivial implications
Browse files Browse the repository at this point in the history
This makes various "hidden" implications created by DeclareProperty
explicit, thus fixing a bunch of warnings that show up if one starts
the upcoming GAP 4.11 with the `-N` command line option, and then
loads this package.

For some information on the background of this, see also
<gap-system/gap#1649> and
<gap-system/gap#2336>
  • Loading branch information
fingolfin committed May 15, 2019
1 parent 5893ee3 commit 526e120
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions lib/cong.gd
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ DeclareCategory( "IsCongruenceSubgroup", IsMatrixGroup );
## [ N 1+N ]
##
DeclareProperty( "IsPrincipalCongruenceSubgroup", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsPrincipalCongruenceSubgroup);


#############################################################################
Expand All @@ -49,6 +50,7 @@ DeclareProperty( "IsPrincipalCongruenceSubgroup", IsCongruenceSubgroup );
## [ N * ]
##
DeclareProperty( "IsCongruenceSubgroupGamma0", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsCongruenceSubgroupGamma0);


#############################################################################
Expand All @@ -60,6 +62,7 @@ DeclareProperty( "IsCongruenceSubgroupGamma0", IsCongruenceSubgroup );
## [ * * ]
##
DeclareProperty( "IsCongruenceSubgroupGammaUpper0", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsCongruenceSubgroupGammaUpper0);


#############################################################################
Expand All @@ -71,6 +74,7 @@ DeclareProperty( "IsCongruenceSubgroupGammaUpper0", IsCongruenceSubgroup );
## [ N 1+N ]
##
DeclareProperty( "IsCongruenceSubgroupGamma1", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsCongruenceSubgroupGamma1);


#############################################################################
Expand All @@ -82,6 +86,7 @@ DeclareProperty( "IsCongruenceSubgroupGamma1", IsCongruenceSubgroup );
## [ * 1+N ]
##
DeclareProperty( "IsCongruenceSubgroupGammaUpper1", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsCongruenceSubgroupGammaUpper1);


#############################################################################
Expand All @@ -93,6 +98,7 @@ DeclareProperty( "IsCongruenceSubgroupGammaUpper1", IsCongruenceSubgroup );
## [ N 1+N ]
##
DeclareProperty( "IsCongruenceSubgroupGammaMN", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsCongruenceSubgroupGammaMN);


#############################################################################
Expand All @@ -106,6 +112,7 @@ DeclareProperty( "IsCongruenceSubgroupGammaMN", IsCongruenceSubgroup );
## CongruenceSubgroupGamma^1 and CongruenceSubgroupGammaMN
##
DeclareProperty( "IsIntersectionOfCongruenceSubgroups", IsCongruenceSubgroup );
InstallTrueMethod(IsCongruenceSubgroup, IsIntersectionOfCongruenceSubgroups);


#############################################################################
Expand Down

0 comments on commit 526e120

Please sign in to comment.