Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine filters for a NormalizerInGLnZ method #5

Merged
merged 1 commit into from
May 28, 2019
Merged

Refine filters for a NormalizerInGLnZ method #5

merged 1 commit into from
May 28, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented May 15, 2019

This fixes a warning that show up if one starts the upcoming GAP 4.11 with the -N command line option, and then loads this package.

For some information on the background of this, see also gap-system/gap#1649 and gap-system/gap#2336

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files           4        4           
  Lines        3063     3063           
=======================================
  Hits         2957     2957           
  Misses        106      106
Impacted Files Coverage Δ
lib/normalizer.gi 18.75% <100%> (ø) ⬆️

@olexandr-konovalov
Copy link
Member

@fingolfin "a bunch" is a one-line change? Probably you mean by "a bunch" that you are adding various related changes to a number of packages, and used some tool to submit many PRs at once?

This fixes a warning that show up if one starts the upcoming GAP 4.11 with the `-N`
command line option, and then loads this package.

For some information on the background of this, see also
<gap-system/gap#1649> and
<gap-system/gap#2336>
@fingolfin fingolfin changed the title Add a bunch of trivial implications Refine filters for a NormalizerInGLnZ method May 20, 2019
@fingolfin
Copy link
Member Author

Yeah, sorry, this commit message is misleading; in fact, there are no implication changes here :-). I've fixed that now.

@gaehler gaehler merged commit 266891b into gap-packages:master May 28, 2019
@fingolfin fingolfin deleted the mh/implications branch May 28, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants