-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PackageInfo.g URLs to point at GitHub #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2019
Hi Max,
This PR only makes senes if a gh-pages branch is set up to enable the new URLs. This is described at length on
https://github.com/gap-system/GitHubPagesForGAP. Alternatively, I can do it for you,
it'll take me about 40 seconds to do.
Yes, please do this for me. Thanks.
It would be great if there was a release of the DESIGN package soon, too. ...
Thank you, and let me know if I can be of any assistance with this. (I think we'll meet in a few weeks in Halle, too).
My plan is to have new versions of both DESIGN and GRAPE ready for release just before or during
GAP Days in Halle, where your help and advice will be much appreciated.
Presumably, similar file changes should be made in GRAPE?
Thanks,
Leonard
…________________________________________
From: Max Horn <notifications@github.com>
Sent: 22 February 2019 14:29:06
To: gap-packages/design
Cc: Subscribed
Subject: [gap-packages/design] Change PackageInfo.g URLs to point at GitHub (#4)
Also rename gpl.txt -> LICENSE.
This PR only makes senes if a gh-pages branch is set up to enable the new URLs. This is described at length on https://github.com/gap-system/GitHubPagesForGAP. Alternatively, I can do it for you, it'll take me about 40 seconds to do.
It would be great if there was a release of the DESIGN package soon, too. It is now the second-oldest distributed package in terms of when its most recent release was; the only older package is repsn, and I just made a release of that.
I realize not that much has changed in DESIGN itself, but already the added tests and the new License field in the PackageInfo.g, plus the issue tracker URL, make it desirable for the GAP team to see this released as 1.6.1 or 1.7. I am sure @alex-konovalov<https://github.com/alex-konovalov> will agree.
Thank you, and let me know if I can be of any assistance with this. (I think we'll meet in a few weeks in Halle, too).
________________________________
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
* PackageInfo.g: change URLs to point to GitHub
* Rename gpl.txt -> LICENSE
File Changes
* R LICENSE<https://github.com/gap-packages/design/pull/4/files#diff-0> (0)
* M PackageInfo.g<https://github.com/gap-packages/design/pull/4/files#diff-1> (128)
Patch Links:
* https://github.com/gap-packages/design/pull/4.patch
* https://github.com/gap-packages/design/pull/4.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#4>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG7QODoM-xPm7MYfJ5Km6PxL9qyjhF7Jks5vP_6ygaJpZM4bJtQK>.
|
Done, result see https://gap-packages.github.io/design/ resp. the There is nothing to be done for GRAPE, as we already performed all these steps there. |
Done, result see https://gap-packages.github.io/design/ resp. the gh-pages branch.
Thank you.
There is nothing to be done for GRAPE, as we already performed all these steps there.
I meant, in GRAPE, should I rename gpl.txt to LICENSE, README to README.md, move the version
changes into a new file new CHANGES.md, and change PackageInfo.g by updating the README_URL
to reflect the change in the readme file name? And what about the file COPYING?
…________________________________________
From: Max Horn <notifications@github.com>
Sent: 23 February 2019 13:58:29
To: gap-packages/design
Cc: Leonard Soicher; State change
Subject: Re: [gap-packages/design] Change PackageInfo.g URLs to point at GitHub (#4)
Done, result see https://gap-packages.github.io/design/ resp. the gh-pages branch.
There is nothing to be done for GRAPE, as we already performed all these steps there.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG7QODidcf8jqWUPaW2rkUwG8V9p57-iks5vQUkFgaJpZM4bJtQK>.
|
Ahh, sorry, I misunderstood. Well, I'd appreciate such changes, but they are not a strict necessity either. Note that renaming README to README.md only makes sense if the file content really is (changed to) Markdown. |
Collaborator
Hi Max,
Ahh, sorry, I misunderstood. Well, I'd appreciate such changes, but they are not a strict necessity either.
Note that renaming README to README.md only makes sense if the file content really is (changed to) Markdown.
I plan to do this, finish off new versions of both GRAPE and DESIGN, and release these new versions during the
GAP Days workshop next week. I look forward to seeing you there, and will likely need some of your expert
help and advice!
Leonard
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename gpl.txt -> LICENSE.
This PR only makes senes if a
gh-pages
branch is set up to enable the new URLs. This is described at length on https://github.com/gap-system/GitHubPagesForGAP. Alternatively, I can do it for you, it'll take me about 40 seconds to do.It would be great if there was a release of the DESIGN package soon, too. It is now the second-oldest distributed package in terms of when its most recent release was; the only older package is repsn, and I just made a release of that.
I realize not that much has changed in DESIGN itself, but already the added tests and the new
License
field in thePackageInfo.g
, plus the issue tracker URL, make it desirable for the GAP team to see this released as 1.6.1 or 1.7. I am sure @alex-konovalov will agree.Thank you, and let me know if I can be of any assistance with this. (I think we'll meet in a few weeks in Halle, too).