Start to make the code compatible with MatrixObj #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 67.87% 67.89% +0.02%
==========================================
Files 4 4
Lines 2991 2993 +2
==========================================
+ Hits 2030 2032 +2
Misses 961 961
|
- replace uses of `Length` by `NrRows` or `NrCols` - replace `mat[i][j]` by `mat[i,j]` This requires GAP >= 4.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LengthbyNrRowsorNrColsmat[i][j]bymat[i,j]This requires GAP >= 4.9.
This is a first step towards addressing issue #7 raised by @ThomasBreuer. Much more is needed (e.g.
BaseDomainshould be used), but this first step should be uncontroversial (plus I think it is helpful to not do too much in a single PR anyway).