FR broken with GAP master branch

[olexandr-konovalov]

gap-system/gap#3370 breaks FR package - see https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master/jobs/519813674 :

Syntax error: ; expected in /home/gap/inst/gap-master/pkg/fr-2.4.6/gap/cp.gi:5\
90
#%%%%%%%%%%%%%%%%%%%%	 RepresentativeActionOp %%%%%%%%%%%%%%%%%%%#
                     	                        ^

There is an easy fix for this - just change formatting of comments. However, it seems to me that there are other diffs, appearing a day before in https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master/jobs/519063953 for the first time - there was some other change in GAP master branch that triggered them.

[olexandr-konovalov]

gap-system/gap#3410 should fix part of the problems, namely arising from code for pragmas wrongly parsing the comment. The other tests will still fail.

[olexandr-konovalov]

@laurentbartholdi please see gap-system/gap#3418 - what do you think of using an option suggested there?

[laurentbartholdi]

Hi, I haven't followed very carefully the thread -- but I don't think it's a good idea to add options in front the avoid the trap. Indeed, how will another developer in the same situation know that some black magic is required? If FR is using the wrong functions, I'm happy to change it. Otherwise, the assert/issubgroup call should have the responsibility of setting options so as to avoid the trap.

[olexandr-konovalov]

gap-system/gap#3425 has been merged, with "noassert" option added in gap-system/gap@b6e34f0.

@laurentbartholdi will you be able to make use of the "noassert" option and publish a new release, please?

[olexandr-konovalov]

This now happens in the stable-4.10 branch too. It used to pass tests in stable-4.10, e.g. https://travis-ci.org/gap-infra/gap-docker-pkg-tests-stable-4.10/jobs/541247926 but not any more (https://travis-ci.org/gap-infra/gap-docker-pkg-tests-stable-4.10/jobs/545256760):

     100 ms (100 ms GC) and 46.1KB allocated for chapter-12.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/chapter-3.tst
     520 ms (136 ms GC) and 76.0MB allocated for chapter-3.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/chapter-4.tst
   14220 ms (1904 ms GC) and 1.87GB allocated for chapter-4.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/chapter-5-a.tst
    4528 ms (708 ms GC) and 669MB allocated for chapter-5-a.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/chapter-5-b.tst
    1340 ms (212 ms GC) and 195MB allocated for chapter-5-b.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/cp.tst
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/cp.tst:67
# Input is:
IsConjugate(GrigorchukGroup,pairs[1][1][1],pairs[1][1][2]);
# Expected output:
#I  Init FRBranchGroupConjugacyData
#I  Finished Init FRBranchGroupConjugacyData
true
# But found:
#I  Init FRBranchGroupConjugacyData
Error, recursion depth trap (5000)
########
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/cp.tst:73
# Input is:
SetFRBranchGroupConjugacyData(GuptaSidkiGroup,
 rec(initial_conj_dic:=NewDictionary([One(GuptaSidkiGroup),One(GuptaSidkiGroup\
)],true),
    Branchstructure:=BranchStructure(GuptaSidkiGroup),
    RepSystem:=List(~.Branchstructure.group,x->PreImagesRepresentative(~.Branc\
hstructure.quo,x)))
 );
# Expected output:
# But found:
Error, recursion depth trap (5000)
########
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/cp.tst:78
# Input is:
CallFuncList(function(a,t) 
            local G,D,g,h;
            G:= GuptaSidkiGroup;
            D:= FRBranchGroupConjugacyData(G).initial_conj_dic;
            for g in [a,a^2,t,t^2] do
              for h in [a,a^2,t,t^2] do
               if g<>h then
                AddDictionary(D,[g,h],[]);
               fi;
              od;
            od;
            AddDictionary(D,[a,a],[One(G),a,a^2]);
            AddDictionary(D,[a^2,a^2],[One(G),a,a^2]);
            AddDictionary(D,[t,t],[One(G),,,t,,,t^2]);
            AddDictionary(D,[t^2,t^2],[One(G),,,t,,,t^2]);
          end,GeneratorsOfGroup(GuptaSidkiGroup)
  );
# Expected output:
# But found:
#I  Init FRBranchGroupConjugacyData
Error, recursion depth trap (5000)
########
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/fr-2.4.6/tst/cp.tst:96
# Input is:
IsConjugate(GuptaSidkiGroup,GuptaSidkiGroup.1^GuptaSidkiGroup.2,GuptaSidkiGrou\
p.1);
# Expected output:
true
# But found:
#I  Init FRBranchGroupConjugacyData
Error, recursion depth trap (5000)
########
    4456 ms (744 ms GC) and 646MB allocated for cp.tst
-----------------------------------
total     25164 ms (3804 ms GC) and 3.42GB allocated
              4 failures in 1 of 6 files
#I  Errors detected while testing

A new release would be really useful @laurentbartholdi.

[laurentbartholdi]

There are no problems with the checks now, so I assume the problem is fixed. Feel free to reopen if I missed something.