Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGCHLD handling #5

Open
fingolfin opened this issue Mar 20, 2014 · 3 comments
Open

Fix SIGCHLD handling #5

fingolfin opened this issue Mar 20, 2014 · 3 comments

Comments

@fingolfin
Copy link
Member

SIGCHLD needs to be revised. There is an attempt to that in the code (see commits 48f0f1f and 3905afa), but it currently does not compile with stock GAP, and should probably reverted for the time being.

A proper fix requires changes to GAP itself. Note that other packages (e.g. libsing, which integrates Singular into GAP), will also need to deal with that. So this would be a useful thing anyway.

Max N., Reimer Behrends and Steve Linton already had a discussion about this at some point, so if anybody is interested in working on this, then talking to them might be a good starting point.

fingolfin added a commit that referenced this issue Mar 27, 2014
Revert commits 3905afa and 48f0f1f for now, see issue #5.
@rbehrends
Copy link

The io package should not install a SIGCHLD signal handler for HPC-GAP. HPC-GAP handles these signals in a separate thread and may therefore run waitpid() before io's signal handler can do so, causing io to hang indefinitely. Since the HPC-GAP handler should be able to handle this satisfactorily, there is also no need to have an additional signal handler.

@fingolfin
Copy link
Member Author

This was now partially addressed, at least for non-HPC-GAP, by @ChrisJefferson's recent work. I think HPC-GAP compatibility still needs to be addressed.

@jdemeyer
Copy link

Cross-reference: gap-system/gap#3380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants