Remove NilpotentQuotient for fp-groups #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under normal circumstances, these are never triggered, and a normal user has no good way to ever use them. On the other hand, a pro user can easily get the same effect by replicating what these methods do. So all in all, there seems to be no point in having these methods. In practice, though, due to a fundamental issue with GAP method ranking, it can happen that lpres' NilpotentQuotient methods for fp-groups actually *do* end up being ranked higher than the methods from nq, and I'd argue this is undesirable in general. For details, see <gap-system/gap#2513>
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 40.57% 40.59% +0.02%
==========================================
Files 18 18
Lines 3810 3808 -2
==========================================
Hits 1546 1546
+ Misses 2264 2262 -2
|
|
I agree -- it can't be performance-savvy to convert an Fp group to an Lp one. OTOH, I think that the NilpotentQuotient method outside Lpres can be improved; I'll try to remember which issues there were. |
|
If there are ways to improve it, by all means submit issues or pull requests to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under normal circumstances, these are never triggered, and a normal user has
no good way to ever use them.
On the other hand, a pro user can easily get the same effect by replicating
what these methods do.
So all in all, there seems to be no point in having these methods.
In practice, though, due to a fundamental issue with GAP method ranking, it
can happen that lpres' NilpotentQuotient methods for fp-groups actually do
end up being ranked higher than the methods from nq, and I'd argue this is
undesirable in general. For details, see
gap-system/gap#2513