Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint all files in gap/* + PackageInfo.g, and make some simplifications #29

Closed
wants to merge 17 commits into from
2 changes: 2 additions & 0 deletions .gaplint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
disable:
- align-assignments
1 change: 0 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
- stable-4.12
- stable-4.11
- stable-4.10
- stable-4.9

steps:
- uses: actions/checkout@v4
Expand Down
50 changes: 24 additions & 26 deletions PackageInfo.g
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
#############################################################################
##
#W PackageInfo.g Smallsemi - a GAP library of semigroups
#Y Copyright (C) 2008-2015 Andreas Distler & James D. Mitchell
## PackageInfo.g Smallsemi - a GAP library of semigroups
## Copyright (C) 2008-2024 Andreas Distler & James D. Mitchell
##
## Licensing information can be found in the README file of this package.
##
#############################################################################
##

SetPackageInfo( rec(
SetPackageInfo(rec(
PackageName := "Smallsemi",
Subtitle := "A library of small semigroups",
Version := "0.6.13",
Date := "28/02/2022", # this is in dd/mm/yyyy format
Date := "28/02/2022", # this is in dd/mm/yyyy format
License := "GPL-3.0-or-later",

Persons := [
Expand All @@ -21,34 +21,34 @@ Persons := [
IsAuthor := true,
IsMaintainer := false,
Email := "a.distler@tu-bs.de",
),
),
rec(
LastName := "Mitchell",
FirstNames := "James",
IsAuthor := true,
IsMaintainer := true,
Email := "jdm3@st-and.ac.uk",
WWWHome := "http://tinyurl.com/jdmitchell",
PostalAddress := Concatenation( [
PostalAddress := Concatenation([
"Mathematical Institute\n", "North Haugh\n",
"St Andrews\n", "Fife\n", "KY16 9SS\n", "Scotland"] ),
"St Andrews\n", "Fife\n", "KY16 9SS\n", "Scotland"]),
Place := "St Andrews",
Institution := "University of St Andrews"
)
)
],
Status := "deposited",

PackageWWWHome := "https://gap-packages.github.io/smallsemi/",
README_URL := Concatenation( ~.PackageWWWHome, "README" ),
PackageInfoURL := Concatenation( ~.PackageWWWHome, "PackageInfo.g" ),
README_URL := Concatenation(~.PackageWWWHome, "README"),
PackageInfoURL := Concatenation(~.PackageWWWHome, "PackageInfo.g"),
SourceRepository := rec(
Type := "git",
URL := "https://github.com/gap-packages/smallsemi",
),
IssueTrackerURL := Concatenation( ~.SourceRepository.URL, "/issues" ),
ArchiveURL := Concatenation( ~.SourceRepository.URL,
IssueTrackerURL := Concatenation(~.SourceRepository.URL, " / issues"),
ArchiveURL := Concatenation(~.SourceRepository.URL,
"/releases/download/v", ~.Version,
"/smallsemi-", ~.Version ),
" / smallsemi -", ~.Version),
ArchiveFormats := ".tar.gz",

AbstractHTML :=
Expand All @@ -66,32 +66,31 @@ PackageDoc := rec(
),

Dependencies := rec(
GAP := ">=4.8",
GAP := ">=4.10",
NeededOtherPackages := [],
SuggestedOtherPackages := [],
ExternalConditions :=
["gzip is needed in standard location if data files are used uncompressed"]),
AvailabilityTest := ReturnTrue,
BannerString := Concatenation(
ListWithIdenticalEntries(SizeScreen()[1]-3, '-'), "\n", ~.PackageName,
ListWithIdenticalEntries(SizeScreen()[1] - 3, '-'), "\n", ~.PackageName,
" - ", ~.Subtitle, "\n",
"by ", ~.Persons[1].FirstNames, " ", ~.Persons[1].LastName,
" & " , ~.Persons[2].FirstNames, " ", ~.Persons[2].LastName, "\n",
"For contents, type: ?Smallsemi:\n" ,
" & ", ~.Persons[2].FirstNames, " ", ~.Persons[2].LastName, "\n",
"For contents, type: ?Smallsemi:\n",
"Loading ", ~.PackageName, " ", ~.Version, " ...\n",
ListWithIdenticalEntries(SizeScreen()[1]-3, '-'), "\n" ),
ListWithIdenticalEntries(SizeScreen()[1] - 3, '-'), "\n"),
TestFile := "tst/testall.g",
Keywords := ["small semigroups", "data library", "multiplication tables"],

AutoDoc := rec(
entities := rec(
VERSION := ~.Version,
ARCHIVENAME := Remove( SplitString( ~.ArchiveURL, "/" ) ),
),
ARCHIVENAME := Remove(SplitString(~.ArchiveURL, " / "))),
TitlePage := rec(
Version := Concatenation( "Version ", ~.Version ),
Version := Concatenation("Version ", ~.Version),
Copyright := """
&copyright; 2008-19 A. Distler &amp; J. D. Mitchell.<P/>
&copyright; 2008-24 A. Distler &amp; J. D. Mitchell.<P/>

<Package>Smallsemi</Package> is free software: you can
redistribute it and/or modify it under the terms of the GNU
Expand All @@ -116,7 +115,8 @@ AutoDoc := rec(
Colophon := """
If you find any bugs or have any suggestions or comments, we would
very much appreciate it if you would let us know via our
issue tracker (see <URL>https://github.com/gap-packages/smallsemi/issues</URL>).
issue tracker (see
<URL>https://github.com/gap-packages/smallsemi/issues</URL>).
""",

Acknowledgements := """
Expand All @@ -127,8 +127,6 @@ AutoDoc := rec(
The first author acknowledges financial support of the University
of St Andrews. The second author acknowledges support of EPSRC
grant number GR/S/56085/01.
""",
),
"""),
),
));

Loading
Loading