- fixed (the straight line program for) a wrong class representative #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the table of marks of "2.(A4xA4).2.2"
- added a general test for nonconjugacy
TB
|
See also PR #28 :-) |
|
@gpfeiffer @LiamNaughton it would be really good if you merged either this PR or PR #28 and then made a release. Or, if you are short on time, we are also happy to make that release for you. If it happens soon, we can get a version of tomlib with this fix into GAP 4.11. |
31 tasks
|
Added this to gap-system/gap#2984. @LiamNaughton @gpfeiffer this PR is now two months old, could you please let us know what do you think? |
|
I think this may be closed, as the fix for the same issue was made in #28 and is now in the released version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked that the table of marks of "2.(A4xA4).2.2" is in fact the only one in the library
for which the problem arises that the stored straight line programs are in fact not
class representatives.
For this one table of marks, the proposed change fixes the bug, by replacing one straight line program.
The general code to check this property is in a new test file.
It is called there only for the erroneous table of marks because the runtime is too large for regular automatic tests.