Add a bunch of trivial implications #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes various "hidden" implications created by DeclareProperty explicit, thus fixing a bunch of warnings that show up if one starts the upcoming GAP 4.11 with the `-N` command line option, and then loads this package. For some information on the background of this, see also <gap-system/gap#1649> and <gap-system/gap#2336>
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 83.62% 83.63% +0.01%
==========================================
Files 39 39
Lines 19447 19460 +13
==========================================
+ Hits 16262 16275 +13
Misses 3185 3185
|
|
Has there been a change in GitHub? |
|
GitHub warned me that I was using an old version of Safari - I should have taken notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes various "hidden" implications created by
DeclarePropertyexplicit, thus fixing a bunch of warnings that show up if one starts the upcoming GAP 4.11 with the-Ncommand line option, and then loads this package.For some information on the background of this, see also gap-system/gap#1649 and gap-system/gap#2336