WIP Use bash script to build docker images #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read the discussion around PR #3 and tried to incorporate all suggestions to come as close as possible to @fingolfin vision as described in Issue #1.
The
prepare_gap.shscript does the downloading/cloning, compiling and downloading and compiling of the packages. It has three options-v,-tand-d. The first is to specify a version of GAP, the second to decide whether to download only required packages (argument:minimal) or all packages (argument:full) and the last is to choose whether to build GAP in debug mode or not (argument:0or1).The Dockerfile defines several build targets.
baseis the newest ubuntu with only packages installed that are necessary to download and compile GAP.all-depsthen adds packages required to build all packages.Then there are targets of the form "gap-{minimal,full}(-debug)" that then use the script
prepare_gap.shto build GAP accordingly. Note that we could also use another build argument to decide whether to build a debug version or not. But we cannot easily use a build argument to decide between minimal and full as these are based on different images (namelybaseorall-deps) and Dockerfiles are just not flexible enough to do that (afaik).This PR does not implement correct github actions yet. And there's the question on how to name the various docker images in a consistent way. The dockerfile and script mainly work on my local machine atm some things likely have to be changed to make it work with ghcr.io.
Before I continue with this I'd love to hear feedback and suggestions!