lib: remove pointless computation from PValuation

gap-system · Jan 21, 2017 · 0589f10 · 0589f10
1 parent 3096e36
commit 0589f10
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/numtheor.gi b/lib/numtheor.gi
@@ -1391,7 +1391,7 @@ end );
 
 
 InstallGlobalFunction(PValuation,function(n,p)
-local a,v;
+local v;
   if not IsPrimeInt(p) or not IsRat(n) then
     Error("wrong parameters");
   fi;
@@ -1401,10 +1401,8 @@ local a,v;
     return PValuation(NumeratorRat(n),p)-PValuation(DenominatorRat(n),p);
   elif n<0 then n:=-n;
   fi;
-  a:=1;
   v:=0;
   while n mod p=0 do
-    a:=a*p;
     v:=v+1;
     n:=n/p;
   od;