Skip to content

Commit

Permalink
matobj: revert some Semigroups-related downrankings
Browse files Browse the repository at this point in the history
Four downrankings were added in advance of GAP 4.10, to make
sure that GAP did not break the Semigroups package, but only
one of them was actually required. This commit reverts the
other three.
  • Loading branch information
wilfwilson committed Sep 24, 2019
1 parent fcd1f51 commit 47d259f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
6 changes: 0 additions & 6 deletions lib/matobj.gi
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,6 @@ InstallMethod( Matrix,
#
InstallMethod( Matrix,
[IsSemiring, IsList, IsInt],
# FIXME: Remove this downranking, it was introduced to prevent
# Semigroups from breaking ahead of the 4.10 release
-SUM_FLAGS,
function( basedomain, list, nrCols )
local rep;
rep := DefaultMatrixRepForBaseDomain(basedomain);
Expand All @@ -195,9 +192,6 @@ InstallMethod( Matrix,

InstallMethod( Matrix,
[IsSemiring, IsList],
# FIXME: Remove this downranking, it was introduced to prevent
# Semigroups from breaking ahead of the 4.10 release
-SUM_FLAGS,
function( basedomain, list )
local rep;
if Length(list) = 0 then Error("list must be not empty"); fi;
Expand Down
3 changes: 0 additions & 3 deletions lib/matrix.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1244,9 +1244,6 @@ end );
InstallOtherMethod( BaseDomain,
"generic method for a row vector",
[ IsRowVector ],
# FIXME: Remove this downranking, it was introduced to prevent
# Semigroups from breaking ahead of the 4.10 release
-SUM_FLAGS,
DefaultRing );

InstallOtherMethod( OneOfBaseDomain,
Expand Down

0 comments on commit 47d259f

Please sign in to comment.