Skip to content

Commit

Permalink
addressed the comments, improved the code further
Browse files Browse the repository at this point in the history
- document the arguments of `MakeIsPlistVectorRep`, `MakeIsPlistMatrixRep`,
  in particular the meaning of `check`

- in `MakeIsPlistMatrixRep`, check also `emptyvector`,
  but do *not* check the internal consistency of the vectors in `list`
  (we assume they have been checked when they were created)

- changed argument names in the code:
  use `ncols` instead of `rowlength` or `rl`, use `list` instead of `l`

- use `->` syntax for one-line functions

- set `IsZero` (`IsOne`) in immutable objects created by `ZeroImmutable`
  (`OneImmutable`)

- changed the code such that the mutability of "nested objects"
  fits to the rules for list arithmetic
  (I am not sure whether this is desirable)

- added some tests
  • Loading branch information
ThomasBreuer authored and fingolfin committed Feb 2, 2023
1 parent e7fb973 commit 55dfbe0
Show file tree
Hide file tree
Showing 5 changed files with 424 additions and 374 deletions.
2 changes: 1 addition & 1 deletion lib/matobj.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ InstallMethod( CopySubMatrix,
##
InstallMethod( TransposedMatImmutable,
[ IsMatrixOrMatrixObj ],
TransposedMatMutable );
M -> MakeImmutable( TransposedMatMutable( M ) ) );


#############################################################################
Expand Down
Loading

0 comments on commit 55dfbe0

Please sign in to comment.