Apply Hulpke's suggestion on checking for nilpotency carefully

Also fix an indentation.
gap-system · Nov 4, 2016 · bc47381 · bc47381
1 parent ca04199
commit bc47381
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/grp.gi b/lib/grp.gi
@@ -4678,7 +4678,7 @@ InstallMethod( MinimalNormalSubgroups,
  # should have and IsSolvable check, as well,
  # but methods for solvable groups are only in CRISP
  # which aggeressively checks for solvability, anyway
- if IsNilpotentGroup(G) then
+ if (not HasIsNilpotentGroup(G) and IsNilpotentGroup(G)) then
  return MinimalNormalSubgroups( G );
  fi;
 

diff --git a/lib/grplatt.gi b/lib/grplatt.gi
@@ -2247,7 +2247,7 @@ local n,i,s;
  # should have and IsSolvable check, as well,
  # but methods for solvable groups are only in CRISP
  # which aggeressively checks for solvability, anyway
- if IsNilpotentGroup(G) then
+ if (not HasIsNilpotentGroup(G) and IsNilpotentGroup(G)) then
  return Socle(G);
  fi;