Skip to content

Commit

Permalink
Fix bad BaseDomain method for IsMatrix and IsPlistRep
Browse files Browse the repository at this point in the history
However, the new method still is not correct, as it would fail
for matrices which are not defined over fields, e.g. over Integers mod 4.
  • Loading branch information
fingolfin committed Mar 2, 2020
1 parent ea09369 commit f8f3ea1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/matrix.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1281,7 +1281,7 @@ InstallOtherMethod( ConstructingFilter,
InstallOtherMethod( BaseDomain,
"generic method for a matrix that is a plain list",
[ IsMatrix and IsPlistRep ],
mat -> BaseDomain( mat[1] ) );
mat -> DefaultFieldOfMatrix( mat ) );

InstallOtherMethod( OneOfBaseDomain,
"generic method for a matrix that is a plain list",
Expand Down

0 comments on commit f8f3ea1

Please sign in to comment.