Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused kernel function 8Bits_Quotient, 16Bits_Quotient and 32Bits_Quotient -- use or remove? #2504

Closed
fingolfin opened this issue Jun 1, 2018 · 0 comments
Closed

Unused kernel function 8Bits_Quotient, 16Bits_Quotient and 32Bits_Quotient -- use or remove? #2504

fingolfin opened this issue Jun 1, 2018 · 0 comments
Labels
kind: discussion discussions, questions, requests for comments, and so on

Comments

@fingolfin
Copy link
Member

While working on PR #2499 I discovered that the kernel functions 8Bits_Quotient, 16Bits_Quotient and 32Bits_Quotient are never used, though in theory we could install them as methods for computing quotients of associative words in syllable representation.

Pros: they might be faster than using inverson + multplication
Con: Since they were never used, they are mostly untested, and might not work correctly.

Thoughts? Pinging esp. @ThomasBreuer and @hulpke as their names appear on lib/wordrep.gi
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 4, 2018
@fingolfin
Install {8,16,32}Bits_Quotient kernel funcs as methods
916c40d 
Resolves gap-system#2504
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 4, 2018
@fingolfin
kernel: remove unused {8,16,32}Bits_Quotient
d11494d 
Resolves gap-system#2504
This was referenced Jul 4, 2018
Closed
Merged
fingolfin added a commit to fingolfin/gap that referenced this issue Jul 5, 2018
@fingolfin
Install {8,16,32}Bits_Quotient kernel funcs as methods
7464992 
Resolves gap-system#2504
fingolfin added a commit that referenced this issue Jul 5, 2018
@fingolfin
Install {8,16,32}Bits_Quotient kernel funcs as methods
c27fca3 
Resolves #2504
@fingolfin fingolfin added kind: discussion discussions, questions, requests for comments, and so on and removed kind: discussion discussions, questions, requests for comments, and so on kind: question labels Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: discussion discussions, questions, requests for comments, and so on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin