Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in MeetOfPartialPerms #1035

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

james-d-mitchell
Copy link
Contributor

Please make sure that this pull request:

  • is submitted to the correct branch (the stable branch is only for bugfixes)
  • contains an accurate description of changes for the release notes below
  • provides new tests or relies on existing ones
  • correctly refers to other issues and related pull requests

Tick all what applies to this pull request

  • Adds new features
  • Improves and extends functionality
  • Fixes bugs that could lead to crashes
  • Fixes bugs that could lead to incorrect results
  • Fixes bugs that could lead to break loops

Write below the description of changes (for the release notes)

Previously if the argument was empty or of length 1, then this function
would error by trying to access unbound list entries. This commit fixes this, and adds tests.

Previously if the argument was empty or of length 1, then this function
would return an error. This commit fixes this, and adds tests.
@codecov-io
Copy link

Current coverage is 49.58% (diff: 100%)

Merging #1035 into master will increase coverage by 0.05%

@@             master      #1035   diff @@
==========================================
  Files           424        424          
  Lines        223274     223277     +3   
  Methods        3430       3430          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         110593     110710   +117   
+ Misses       112681     112567   -114   
  Partials          0          0          

Powered by Codecov. Last update 458ab05...492045b

@markuspf markuspf merged commit 4ff9b38 into gap-system:master Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants