Make profiling correctly handle the same file being opened multiple times #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
profile-multifile
branch
from
2f1c569
to
500c698
Compare
fingolfin
approved these changes
Jan 12, 2017
Current coverage is 54.12% (diff: 100%)@@ master #1069 diff @@
==========================================
Files 429 429
Lines 226660 226662 +2
Methods 3435 3436 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 122661 122687 +26
+ Misses 103999 103975 -24
Partials 0 0
|
ChrisJefferson
force-pushed
the
profile-multifile
branch
from
500c698
to
66d03e7
Compare
|
Sorry, made a change after sleeping on the patch -- realised that I was storing a GAP string in a C structure which might get garbage collected! Now using copy of string in a structure which I know won't get GCed. |
|
Ahh, that's quite subtle -- good thinking :) |
ChrisJefferson
force-pushed
the
profile-multifile
branch
from
66d03e7
to
d1af6de
Compare
|
Can you perhaps edit the commit message and elaborate; e.g. copy the description of this PR, perhaps add the note in your last commen? |
This patch ensures when reopening a file we check if the filename has been opened previously, and if so associate it with the same filename number. This is tested in the 'profiling' package, which is why there is no tests here.
ChrisJefferson
force-pushed
the
profile-multifile
branch
from
d1af6de
to
bc95e8b
Compare
|
Better commit message. Also since writing this I've put tests into the profiling package to check reading a file multiple times works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes profiling correctly handle the same file being opened multiple times, by associating it with the same integer filename.
This is unfortunately hard to automatically test -- but I've tested it manually for a few tests and it works fine (the profiling should have a better automated testsuite...).
This doesn't require a change in profiling, and should work with any version.