Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SyCacheSize and the "-c" command line option #1192

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

fingolfin
Copy link
Member

This code was meant as an optimization for CPUs with data cache (i.e.
nowadays every CPU), but in practice it seems to have no noticeable
impact.

Resolves #273

@codecov
Copy link

codecov bot commented Mar 17, 2017

Codecov Report

Merging #1192 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
+ Coverage   55.11%   55.12%   +<.01%     
==========================================
  Files         935      935              
  Lines      293004   292987      -17     
  Branches    18306    18302       -4     
==========================================
- Hits       161501   161496       -5     
+ Misses     128519   128510       -9     
+ Partials     2984     2981       -3
Impacted Files Coverage Δ
hpcgap/src/gap.c 14.75% <ø> (ø) ⬆️
src/system.c 52.81% <ø> (-0.09%) ⬇️
src/hpc/boehm_gc.h 71.22% <ø> (ø) ⬆️
hpcgap/src/system.c 25.14% <ø> (-0.15%) ⬇️
lib/system.g 66.97% <ø> (ø) ⬆️
src/gap.c 52.54% <ø> (-0.04%) ⬇️
src/gasman.c 78.84% <100%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6718d...b67fc6b. Read the comment docs.

@olexandr-konovalov olexandr-konovalov added the gapdays2017-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2017-spring label Mar 18, 2017
This code was meant as an optimization for CPUs with data cache (i.e.
nowadays every CPU), but in practice it seems to have no noticeable
impact.

Resolves gap-system#273
@markuspf markuspf merged commit d90ec2f into gap-system:master Apr 8, 2017
@fingolfin fingolfin deleted the mh/SyCacheSize branch April 13, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2017-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2017-spring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants