Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the -X command line option, and various other tweaks #1421

Merged
merged 6 commits into from
Jun 16, 2017

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #1421 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
+ Coverage   63.43%   63.43%   +<.01%     
==========================================
  Files        1011     1011              
  Lines      339046   339019      -27     
  Branches    13753    13744       -9     
==========================================
+ Hits       215059   215068       +9     
+ Misses     120925   120895      -30     
+ Partials     3062     3056       -6
Impacted Files Coverage Δ
src/system.c 53.87% <ø> (-0.08%) ⬇️
hpcgap/lib/system.g 65.75% <ø> (ø) ⬆️
lib/system.g 66.97% <ø> (ø) ⬆️
src/sysfiles.c 30.39% <25%> (-0.07%) ⬇️
src/gap.c 55.34% <25%> (+0.09%) ⬆️
src/streams.c 46.38% <50%> (+0.6%) ⬆️
src/objset.c 41.02% <0%> (-0.29%) ⬇️
src/hpc/thread.c 46.35% <0%> (-0.2%) ⬇️
hpcgap/src/stats.c 73.02% <0%> (-0.14%) ⬇️
src/funcs.c 62.97% <0%> (+0.14%) ⬆️
... and 5 more

This also removes the global variable SyCheckCRCCompiledModule.
Note: This does not remove the CRC checks for GAP files compiled to C
cod by GAC. Rather, the removed code was a left-over from the long-gone
"completion" mechanism. It did not actually do anything, because the
only call to SyFindOrLinkGapRootFile hardcoded 0 as reference CRC.
@fingolfin fingolfin merged commit 98e6b72 into gap-system:master Jun 16, 2017
@fingolfin fingolfin deleted the mh/load-module-crc branch June 16, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants