Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to reesmat code and new tests #1676

Merged
merged 10 commits into from
Sep 7, 2017
Merged

Improvements to reesmat code and new tests #1676

merged 10 commits into from
Sep 7, 2017

Commits on Sep 6, 2017

  1. reesmat: fix IsFinite for RMS and RZMS 

    Previously, IsFinite used the logic that for a subsemigroup <S> of a
Rees (0-)matrix semigroup <R>, <S> is finite if and only if <R> is
finite. You can use the information that <R> is finite to deduce that
<S> is finite, but if <R> is infinite you cannot immediately deduce the
(in)finiteness of <S>.

Resolves gap-system#1659
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    99776b1 View commit details
    Browse the repository at this point in the history

  2. reesmat: remove IsOne for RZMS elts 

    IsOne: IsOne for a Rees (0-)matrix semigroup element doesn't make sense,
since a Rees (0-)matrix semigroup is never IsMagmaWithOne. Furthermore,
even interpreting `IsOne` as menaing `IsMultiplicativeNeutralElement`,
the methods were invalid. Therefore, I've removed them.

Resolves gap-system#1661
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    01f7d94 View commit details
    Browse the repository at this point in the history

  3. reesmat: rewrite IsIdempotent 

    This is a very minor change which (in my opinion) makes the code more
readable, and seems to have no effect on performance.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    3d4b12e View commit details
    Browse the repository at this point in the history

  4. reesmat: generalise IsRegularSemigroup method 

    This is a very minor change, which means that the good method in
`IsRegularSemigroup` applies to a slightly larger class of argument.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    82905f0 View commit details
    Browse the repository at this point in the history

  5. reesmat: fix IsReesZeroMatrixSemigroup 

    This commit fixes a bug that could lead to a break loop, and also
replaces the statement `return Size(ParentAttr(R)) = 1;` with `return
false`, since a Rees 0-matrix semigroup is never trivial.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    a7d3c10 View commit details
    Browse the repository at this point in the history

  6. reesmat: improve arg checking in RZMS

    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b5229d4 View commit details
    Browse the repository at this point in the history

  7. reesmat: cleanup IsZeroSimpleSemigroup 

    This commit shortens a method for `IsZeroSimpleSemigroup`, so that it
uses `ForAll` and `ForAny` instead of loops; I think this is more
readable.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    7515953 View commit details
    Browse the repository at this point in the history

  8. reesmat: remove redundant/invalid code from IsRMS 

    In IsReesMatrixSemigroup, this commit removes some code that I believe
is unreachable for finite semigroups, and invalid for infinite
semigroups. It had no test coverage previously.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    d694876 View commit details
    Browse the repository at this point in the history

  9. reesmat: fix bug in Enumerator 

    This commit fixes a bug whereby an Enumerator of a Rees (0-)matrix
semigroup believed that it contains elements from a different Rees
(0-)matrix semigroup.
    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    1595a2f View commit details
    Browse the repository at this point in the history

  10. reesmat: increase code coverage

    @wilfwilson
    wilfwilson committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    a914d63 View commit details
    Browse the repository at this point in the history