Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion fix to correctly reset RecursionDepth whenever a longjmp occurs #1753

Merged
merged 2 commits into from
Oct 2, 2017

Conversation

ChrisJefferson
Copy link
Contributor

This ensures we correctly reset RecursionDepth whenever a longjmp occurs.

@wilfwilson
Copy link
Member

Thanks a lot for sorting this out Chris

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #1753 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   63.43%   63.44%   +<.01%     
==========================================
  Files        1000     1000              
  Lines      322760   322763       +3     
  Branches    13015    13038      +23     
==========================================
+ Hits       204757   204766       +9     
+ Misses     115361   115358       -3     
+ Partials     2642     2639       -3
Impacted Files Coverage Δ
src/funcs.c 72.25% <100%> (+1.09%) ⬆️
src/system.c 51.68% <0%> (-0.34%) ⬇️
hpcgap/lib/hpc/stdtasks.g 38.61% <0%> (-0.26%) ⬇️
src/stats.c 73.36% <0%> (-0.14%) ⬇️
src/gap.c 56.03% <0%> (-0.09%) ⬇️
src/hpc/traverse.c 78.29% <0%> (+0.08%) ⬆️
src/hpc/threadapi.c 34.55% <0%> (+0.09%) ⬆️
src/lists.c 55.08% <0%> (+0.11%) ⬆️
src/hpc/thread.c 46.83% <0%> (+0.39%) ⬆️

@markuspf markuspf merged commit fe0f45e into gap-system:master Oct 2, 2017
@ChrisJefferson ChrisJefferson deleted the recursion-fix branch November 6, 2017 12:44
@olexandr-konovalov olexandr-konovalov changed the title Recursion fix Recursion fix to correctly reset RecursionDepth whenever a longjmp occurs Jan 22, 2018
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 22, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants