Removed SmallGroup call from HPC-GAP test #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it will fail after the switch to the SmallGrp package as it is not yet HPC-GAP ready.
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
==========================================
+ Coverage 60.92% 60.92% +<.01%
==========================================
Files 997 997
Lines 301950 301950
Branches 13036 13060 +24
==========================================
+ Hits 183968 183972 +4
Misses 115333 115333
+ Partials 2649 2645 -4
|
ChrisJefferson
approved these changes
Oct 4, 2017
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it will fail after the switch to the SmallGrp package as it is not yet HPC-GAP ready.
I suggest to do this to allow to pick up SmallGrp package and cleanly merge #1714 - latter work on updating SmallGrp to work in HPC-GAP will not require pull requests as it will be picked up via package updates.