Fix DisplaySemigroup for transformation semigroups #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
kind: enhancement
fingolfin
reviewed
Oct 19, 2017
lib/semigrp.gi
Outdated
| Representative(h))) / Size(h); | ||
| Print("[H size = ", Size(h), ", ", nrL, " L-class"); | ||
| if nrL > 1 then | ||
| Print("es"); |
There was a problem hiding this comment.
You use 2 spaces for indentation here, while earlier in this function, 4 spaces are used...
There was a problem hiding this comment.
Good point @fingolfin, I'll unify it to 4 spaces (the original number used by this method).
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
+ Coverage 62.82% 62.83% +0.01%
==========================================
Files 969 969
Lines 295190 295205 +15
Branches 13049 13049
==========================================
+ Hits 185449 185494 +45
+ Misses 106940 106911 -29
+ Partials 2801 2800 -1
|
The documentation for `DisplaySemigroup` was not linked. Furthermore, there was an unexpected error for certain types of transformation semigroup when using `DisplaySemigroup`: in particular, the method did not take into account the degree of the semigroup when trying to calculate the rank of an element. For example, in any monoid of transformations of degree `n`, `IdentityTransformation` has rank `n`. So you need to know the degree of the semigroup to get the rank.
wilfwilson
force-pushed
the
fix-DisplaySemigroup
branch
from
16090c2 to
8a35b08
Compare
james-d-mitchell
approved these changes
Oct 26, 2017
olexandr-konovalov
added
the
release notes: added
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisplaySemigroupis supposed to give a summary of the Green's structure of a transformation semigroup.The documentation for
DisplaySemigroupwas not linked into the documentation system. I have now linked this, and reworded the documentation slightly.I have changed the code of
DisplaySemigroupso that the output is more readable (and correctly pluralises the word "class").Furthermore, there was an unexpected error for certain types of transformation semigroup when using
DisplaySemigroup. This was because the method did not take into account the degree of the semigroup when trying to calculate the rank of an element. For example, in any monoid of transformations of degreen, theIdentityTransformationhas rankn. So you need to know the degree of the semigroup in order to get the rank of any element.