Allow profiling of memory usage #1808
Conversation
ChrisJefferson
force-pushed
the
prof-improve
branch
from
31a86c9 to
ad119a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 62.82% 63.03% +0.21%
==========================================
Files 969 969
Lines 291588 292296 +708
Branches 12717 12730 +13
==========================================
+ Hits 183182 184255 +1073
- Misses 105108 105272 +164
+ Partials 3298 2769 -529
|
|
I tried to profile testinstall with this. I got a 500MB compressed profile which I can't read in a 30GB workspace. I've previously had problems with some very large profiles, but not this extreme. The profile is 40GB uncompressed, which I guess is the problem, but it is a serious limitation on what I can use it for. |
|
I'm going to look into the memory usage -- there shouldn't be a need to use that much memory, let me have a look. |
src/profile.c
Outdated
| @@ -343,35 +359,33 @@ static inline void outputStat(Stat stat, int exec, int visited) | |||
| { | |||
|
|
|||
| if(profileState.OutputRepeats) { | |||
There was a problem hiding this comment.
While add it, perhaps also change this if( to if (?
src/profile.c
Outdated
| @@ -416,12 +430,12 @@ void visitStat(Stat stat) | |||
|
|
|||
| void outputVersionInfo(void) | |||
| { | |||
| fprintf(profileState.Stream, | |||
| char timeTypeNames[3][10] = { "WallTime", "CPUTime", "Memory" }; | |||
src/profile.c
Outdated
|
|
||
| GVAR_FUNC(ACTIVATE_PROFILING, 4, "string,boolean,boolean,integer"), | ||
| GVAR_FUNC( | ||
| ACTIVATE_PROFILING, 5, "string,boolean,boolean,boolean,integer"), |
There was a problem hiding this comment.
Why isn't this "filename,coverage,wallTime,recordMem,resolution"? Using the argument names is the convention in all other files, at least.
src/system.c
Outdated
| happen early enough */ | ||
| { 0, "prof", enableProfilingAtStartup, 0, | ||
| 1 }, /* enable profiling at startup */ | ||
| { 0, "memprof", enableMemoryProfilingAtStartup, 0, |
There was a problem hiding this comment.
Reformatting all of options makes it difficult to spot what you actually changed :/
ChrisJefferson
force-pushed
the
prof-improve
branch
2 times, most recently
from
3608dcc to
5082831
Compare
ChrisJefferson
force-pushed
the
prof-improve
branch
from
5082831 to
e3a7394
Compare
|
I believe all issues are fixed. |
|
Looks good to me. |
olexandr-konovalov
added
the
release notes: added
This PR adds an option to
LineByLineProfile,recordMemwhich allows profiling memory usage, rather than CPU usage.It would be very simple (in the kernel) to allow profiling both time and memory at the same time, but the code in the profiling package to parse the result is quite horrible, so if someone wanted that they would have to edit both bits of code in sync.