Introduce kernel-level LCM_INT #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
force-pushed
the
add-lcm-kernel
branch
from
dd150fe
to
9799a6b
Compare
fingolfin
approved these changes
Dec 12, 2017
src/integer.c
Outdated
| @@ -2202,6 +2202,43 @@ Obj FuncGCD_INT ( Obj self, Obj opL, Obj opR ) | |||
| return GcdInt( opL, opR ); | |||
| } | |||
|
|
|||
| Obj LcmInt ( Obj opL, Obj opR ) | |||
There was a problem hiding this comment.
I recently started using clang-format for new entries in this file (and a few older ones). Perhaps use this here, too? I.e. just do git clang-format HEAD^ && git commit --amend -C HEAD
markuspf
force-pushed
the
add-lcm-kernel
branch
from
9799a6b
to
33ec3d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 66% 66.02% +0.01%
==========================================
Files 898 898
Lines 273275 273285 +10
Branches 12745 12773 +28
==========================================
+ Hits 180384 180424 +40
+ Misses 90069 90038 -31
- Partials 2822 2823 +1
|
markuspf
force-pushed
the
add-lcm-kernel
branch
3 times, most recently
from
ba3cff6
to
64f783c
Compare
|
BTW, we don't seem to have any test cases for |
markuspf
force-pushed
the
add-lcm-kernel
branch
from
64f783c
to
7dbede5
Compare
This is done using the gmp function mpz_lcm.
markuspf
force-pushed
the
add-lcm-kernel
branch
from
7dbede5
to
13118fe
Compare
ChrisJefferson
approved these changes
Dec 17, 2017
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done using the gmp function mpz_lcm. For large integers this leads to some speedup (over the GAP variant) when computing least common multiples.
I am not entirely sure whether this is worth it, but I open the pull request just in case. The background is that I compute the LCM of a very long list of fairly large integers.
A further pull request (which has a much bigger impact for my examples) will provide a divide-and-conquer folding function for lists.