JenningsLieAlgebra #2079
JenningsLieAlgebra #2079
Conversation
Fixed a bug reported by Laurent Bartholdi. Here is an example showing the correct behaviour: gap> g := Group((1,10)(2,9)(3,11)(4,12)(5,15)(6,16)(7,13)(8,14)(17,21)(18,22)* > (19,24)(20,23)(25,27)(26,28)(29,30)(33,51)(34,52)(35,49)(36,50)(37,54)(38,53)* > (39,55)(40,56)(41,61)(42,62)(43,64)(44,63)(45,57)(46,58)(47,60)(48,59), > (1,19)(2,20)(3,17)(4,18)(5,22)(6,21)(7,23)(8,24)(9,29)(10,30)(11,32)(12,31)* > (13,25)(14,26)(15,28)(16,27)(33,42)(34,41)(35,43)(36,44)(37,47)(38,48)(39,45)* > (40,46)(49,53)(50,54)(51,56)(52,55)(57,59)(58,60)(61,62), > (1,37)(2,38)(3,40)(4,39)(5,33)(6,34)(7,36)(8,35)(9,43)(10,44)(11,41)(12,42)* > (13,46)(14,45)(15,47)(16,48)(17,58)(18,57)(19,59)(20,60)(21,63)(22,64)(23,61)* > (24,62)(25,50)(26,49)(27,51)(28,52)(29,55)(30,56)(31,53)(32,54)); <permutation group with 3 generators> gap> L:= JenningsLieAlgebra(g); <Lie algebra of dimension 13 over GF(2)> gap> List(Basis(L),PthPowerImage); [ 0*v.1, v.6, 0*v.1, v.7, v.8, v.9, 0*v.1, v.10, v.11, v.12, 0*v.1, v.13, 0*v.1 ] gap> LieLowerCentralSeries(L); [ <Lie algebra of dimension 13 over GF(2)>, <Lie algebra of dimension 3 over GF(2)>, <Lie algebra of dimension 0 over GF(2)> ]
removed a line break...
|
Without knowing what's going on, could you add a test, please? (For example testing the above example, feel free to add more ;)) |
|
Hi,
I tried to add a test in the commit message. Don't know how to add one
otherwise.
In any case, here it is:
gap> g :=
Group((1,10)(2,9)(3,11)(4,12)(5,15)(6,16)(7,13)(8,14)(17,21)(18,22)*
(19,24)(20,23)(25,27)(26,28)(29,30)(33,51)(34,52)(35,49)(36,50)(37,54)(38,53)*
(39,55)(40,56)(41,61)(42,62)(43,64)(44,63)(45,57)(46,58)(47,60)(48,59),
(1,19)(2,20)(3,17)(4,18)(5,22)(6,21)(7,23)(8,24)(9,29)(10,30)(11,32)(12,31)*
(13,25)(14,26)(15,28)(16,27)(33,42)(34,41)(35,43)(36,44)(37,47)(38,48)(39,45)*
(40,46)(49,53)(50,54)(51,56)(52,55)(57,59)(58,60)(61,62),
(1,37)(2,38)(3,40)(4,39)(5,33)(6,34)(7,36)(8,35)(9,43)(10,44)(11,41)(12,42)*
(13,46)(14,45)(15,47)(16,48)(17,58)(18,57)(19,59)(20,60)(21,63)(22,64)(23,61)*
(24,62)(25,50)(26,49)(27,51)(28,52)(29,55)(30,56)(31,53)(32,54));
<permutation group with 3 generators>
gap> L:= JenningsLieAlgebra(g);
<Lie algebra of dimension 13 over GF(2)>
gap> List(Basis(L),PthPowerImage);
[ 0*v.1, v.6, 0*v.1, v.7, v.8, v.9, 0*v.1, v.10, v.11, v.12, 0*v.1, v.13,
0*v.1 ]
gap> LieLowerCentralSeries(L);
[ <Lie algebra of dimension 13 over GF(2)>,
<Lie algebra of dimension 3 over GF(2)>,
<Lie algebra of dimension 0 over GF(2)> ]
All the best,
Willem
|
|
@willemdegraaf you can add a test file to the |
fingolfin
added
the
kind: bug
|
Sorry for my ignorance: hoow do I add a file to that directory?
Willem
|
|
@willemdegraaf are you using GitHub's web-interface, or working in a local clone of the repository with git? |
|
Until now I was using the web interface.
|
|
@willemdegraaf then go to the branch corresponding to this pull request in your fork, and navigate there to the directory where you want to create the file - that is given by this link: https://github.com/willemdegraaf/gap/tree/Laurent/tst Now there is a "create new file" button there, click on it, specify the file name, enter the content of the file, then the text of the commit message, and click on "Commit new file" button at the bottom of this page. |
There was a problem hiding this comment.
This PR breaks examples in the manual (see the build log at https://travis-ci.org/gap-system/gap/jobs/327599027):
########> Diff in /home/travis/build/gap-system/gap/doc/ref/../../lib/alglie.g\
d:1456 (/home/travis/build/gap-system/gap/tst/testmanuals/chapter64.tst:323)
# Input is:
L:= JenningsLieAlgebra( G );
# Expected output:
<Lie algebra of dimension 6 over GF(3)>
# But found:
Error, list entry 7 must lie in [ 1 .. 6 ]
########
########> Diff in /home/travis/build/gap-system/gap/doc/ref/../../lib/alglie.g\
d:1456 (/home/travis/build/gap-system/gap/tst/testmanuals/chapter64.tst:327)
# Input is:
PthPowerImages( Basis( L ) );
# Expected output:
[ v.6, 0*v.1, 0*v.1, 0*v.1, 0*v.1, 0*v.1 ]
# But found:
[ 0*v.1, v.2, 0*v.1, 0*v.1, 0*v.1, 0*v.1, 0*v.1, 0*v.1, 0*v.1, 0*v.1,
0*v.1 ]
########
########> Diff in /home/travis/build/gap-system/gap/doc/ref/../../lib/alglie.g\
d:1456 (/home/travis/build/gap-system/gap/tst/testmanuals/chapter64.tst:329)
# Input is:
g:= Grading( L );
# Expected output:
rec( hom_components := function( d ) ... end, max_degree := 3,
min_degree := 1, source := Integers )
# But found:
Error, no method found! For debugging hints type ?Recovery from NoMeth\
odFound
Error, no 2nd choice method found for `Grading' on 1 arguments
########
########> Diff in /home/travis/build/gap-system/gap/doc/ref/../../lib/alglie.g\
d:1456 (/home/travis/build/gap-system/gap/tst/testmanuals/chapter64.tst:332)
# Input is:
List( [1,2,3], g.hom_components );
# Expected output:
[ <vector space over GF(3), with 3 generators>,
<vector space over GF(3), with 2 generators>,
<vector space over GF(3), with 1 generators> ]
# But found:
Error, Record Element: <rec> must be a record (not a list (plain,rect \
table,imm))
########
chapter64.tst
(Most likely just fixing the 1st example would fix the others)
Fixed stupid additional error; and also the function PCentralLieAlgebra.
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
+ Coverage 67.07% 67.26% +0.19%
==========================================
Files 900 901 +1
Lines 273512 273451 -61
==========================================
+ Hits 183447 183939 +492
+ Misses 90065 89512 -553
Continue to review full report at Codecov.
|
|
Fixed that. Also noted that the same error happens in PCentralLieAlgebra; fixed that as well. |
test file for the fix of JenningsLieAlgebra and also for PCentralLieAlgebra.
|
OK. Did that. Do I now need to do another pull request?
|
|
@willemdegraaf you don't need another PR: because the file was added in the branch from which this PR has been submitted, this PR is now updated automatically. When this PR will be ready, one should perhaps "squash and merge" this to have all changes in a single commit. |
|
@willemdegraaf ... hmm... your new test file will not be picked up by tests, because it is not in the right location - I've overlooked that, because your fork is our of sync, and it does not have the latest state of the Will you be able to use |
|
Yes, I can use git. But it would take some time to learn how to work with
that...
…On 11 January 2018 at 14:10, Alexander Konovalov ***@***.***> wrote:
@willemdegraaf <https://github.com/willemdegraaf> ... hmm... your new
test file will not be picked up by tests, because it is not in the right
location - I've overlooked that, because your fork is our of sync, and it
does not have the latest state of the tst directory, which has a separate
subdirectory for bugfix tests. But first let's see how the currently
running Travis CI tests will go.
Will you be able to use git on your local machine instead of the web
interface? That may be more efficient in the long run.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2079 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALl1FG90k87qK-SmH8p1BGe-YhRAHknNks5tJghDgaJpZM4Rai7e>
.
|
|
@willemdegraaf will be time well invested - better than spending time on trying to use the web interface. Hopefully some of us here may help. To start with, you may try to follow https://github.com/gap-system/gap/blob/master/CONTRIBUTING.md |
|
Good, thank you! I will look at it one of these days.
|
|
P.S. If this is a bugfix, perhaps it should be submitted to stable-4.9 branch. One could edit PR using GitHub web interface to change where it is submitted. |
|
This PR is based on 5343150 from April 2015 (!), i.e. 2.5 years ago. I'll make a new PR with the changes in here, in a single commit and all the problems @alex-konovalov mentioned corrected. |
|
Closed as replaced by #2085. |
Fixed a bug in JenningsLieAlgebra, reported by Laurent Bartholdi.
Here is an example of the correct behaviour: