Gasman fixes for stable-4.9 #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch a couple of cases where we can cause pointer overflow. Also no callers of NewBag or ResizeBag check the return value, so instead of returning 0 on failure exit GAP.
StopBags may be smaller or larger than EndBags, so we cannot use SpaceBetweenPointers. We switch to just using '-'.
The memmove in glibc on 32-bit SSE2 systems, contained in __memmove_sse2_unaligned, is buggy in at least versions 2.21 - 2.25 when crossing the 2GB boundary, so GAP must include it's own simple memmove implementation.
markuspf
approved these changes
Feb 6, 2018
Codecov Report
@@ Coverage Diff @@
## stable-4.9 #2166 +/- ##
==============================================
+ Coverage 69.19% 69.19% +<.01%
==============================================
Files 493 493
Lines 259991 260030 +39
==============================================
+ Hits 179900 179936 +36
- Misses 80091 80094 +3
|
fingolfin
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #2160 and #2151 into 4.9. These fix problems with memmove and gasman.
The patches are mostly identical, just replacing more occurrences of memmove by SyMemmove