Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallImmediateMethod: make rank optional, tweak docs #2244

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Mar 5, 2018

Make the <rank> argument to InstallImmediateMethod optional (if omitted, 0 is used as default value).

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Mar 5, 2018
@fingolfin fingolfin requested a review from markuspf March 5, 2018 22:50
Clarify in the InstallImmediateMethod documentation that <info> is
an optional argument. Moreover, make the <rank> optional, too
(if omitted, 0 is used as default value).
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #2244 into master will increase coverage by <.01%.
The diff coverage is 86.44%.

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
+ Coverage   70.34%   70.34%   +<.01%     
==========================================
  Files         481      481              
  Lines      253181   253212      +31     
==========================================
+ Hits       178091   178127      +36     
+ Misses      75090    75085       -5
Impacted Files Coverage Δ
hpcgap/src/c_oper1.c 90% <100%> (+0.02%) ⬆️
src/c_oper1.c 91.31% <100%> (+0.02%) ⬆️
lib/oper.g 78.55% <77.14%> (+0.98%) ⬆️
src/hpc/traverse.c 95.45% <0%> (-0.03%) ⬇️
src/gap.c 63.52% <0%> (+0.33%) ⬆️

@fingolfin fingolfin merged commit 65d7715 into gap-system:master Mar 21, 2018
@fingolfin fingolfin deleted the mh/InstallImmediateMethod branch March 21, 2018 10:34
@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Jul 31, 2018
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants