Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit implications #2247

Closed
wants to merge 1 commit into from

Conversation

frankluebeck
Copy link
Member

WORK IN PROGRESS

This is a start to add explicit implications to the GAP library that can
substitute the undocumented "hidden implications" which GAP uses so far for
the computation of filter ranks and when checking if installed methods
correspond to appropriate declarations.

Here, we only add implications which are explicitly mentioned in the
documentation.

It can be debugged (see branch fl_nohiddenamps) that the changes here have
almost no impact on the relative ranks of methods. Using the -N switch
from the mentioned branch one can call gap -A -N without any messages from
InstallMethod. But there is still some work to do because many filters have
a much lower rank without hidden implications and a few rank changes of
methods may need to be fixed.

WORK IN PROGRESS

This is a start to add explicit implications to the GAP library that can
substitute the undocumented "hidden implications" which GAP uses so far for
the computation of filter ranks and when checking if installed methods
correspond to appropriate declarations.

Here, we only add implications which are explicitly mentioned in the
documentation.

It can be debugged (see branch fl_nohiddenamps) that the changes here have
almost no impact on the relative ranks of methods. Using the -N switch
from the mentioned branch one can call gap -A -N without any messages from
InstallMethod. But there is still some work to do because many filters have
a much lower rank without hidden implications and a few rank changes of
methods may need to be fixed.
@frankluebeck
Copy link
Member Author

The motivation of this patch is similar to that of #2222. There may be some intersection (but hopefully no conflict).

Using the debugging switch -N provided by #2246 and this patch one can call gap -A -N without complaining messages from InstallMethod. But there is still something to do to get all filter ranks to similar values as before without hidden implications.

@frankluebeck frankluebeck added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Mar 6, 2018
@fingolfin
Copy link
Member

This has been rendered obsolete by the merge of PR #2222

@fingolfin fingolfin closed this Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants