Fix incorrect IsFinitelyGeneratedMonoid method #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
ThomasBreuer
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
Thanks for this fix.
(In an ideal world, there would be no properties IsFinitelyGeneratedMonoid and IsFinitelyGeneratedGroup, see the discussion about #2252.)
A finite generating set implies finite generation; but an infinite generating set does not mean that there cannot be a finite one, too.
fingolfin
force-pushed
the
mh/fix-IsFinitelyGeneratedMonoid
branch
from
3ebffe0
to
8a338d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 71.36% 71.36% -0.01%
==========================================
Files 480 480
Lines 253198 253202 +4
==========================================
+ Hits 180697 180698 +1
- Misses 72501 72504 +3
|
|
Yes, I agree on the "ideal world" remark, and I hope we can get there -- I just thought that in the meantime, it'd be a good idea to fix the bugs immediately as I notice them |
|
There was a test which required infinitely generated free monoids to know have |
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we also have
IsFinitelyGeneratedMonoid(which I did not realize), and we also have an invalid method for that (see PR #2275).