Avoid GC problem in PowPerm2Int/PowPerm4Int #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AInvInt can cause a garbage collection, which moves the memory that ptKnown points to.
ChrisJefferson
added
kind: bug: crash
Codecov Report
@@ Coverage Diff @@
## master #2320 +/- ##
==========================================
+ Coverage 64.59% 72.33% +7.74%
==========================================
Files 478 479 +1
Lines 250875 250961 +86
==========================================
+ Hits 162046 181533 +19487
+ Misses 88829 69428 -19401
|
fingolfin
approved these changes
Mar 28, 2018
fingolfin
added
release notes: added
|
Backported (with minor necessary adjustment) to stable-4.9 as 15ce49d |
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AInvInt can cause a garbage collection, which moves the memory that ptKnown points to, so calculate the negation first.