Fix GC bug in FuncCOMPONENTS_TRANS #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `NEW_PLIST` can cause a garbage collection, which would render the `seen` pointer returned by `ResizeInitTmpTrans` invalid. Also simplify some similar (but not buggy) code in `FuncIMAGE_SET_TRANS_INT` Fixes gap-system#2333
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #2353 +/- ##
==========================================
+ Coverage 73.13% 73.13% +<.01%
==========================================
Files 482 482
Lines 246496 246495 -1
==========================================
+ Hits 180265 180266 +1
+ Misses 66231 66229 -2
|
ChrisJefferson
approved these changes
Apr 12, 2018
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
NEW_PLISTcan cause a garbage collection, which would render theseenpointer returned byResizeInitTmpTransinvalid.Also simplify some similar (but not buggy) code in
FuncIMAGE_SET_TRANS_INTFixes #2333