Overview of changes in GAP 4.9.1 release #2418

olexandr-konovalov · 2018-04-27T11:02:55Z

This PR adds new Chapter to the Changes manual. It is based on wiki page https://github.com/gap-system/gap/wiki/GAP-4.9-release-notes

codecov · 2018-04-27T22:19:50Z

Codecov Report

Merging #2418 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2418   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files         484      484           
  Lines      245454   245454           
=======================================
  Hits       181541   181541           
  Misses      63913    63913

Impacted Files	Coverage Δ
src/gasman.c	`85.37% <0%> (-0.19%)`	⬇️
src/hpc/threadapi.c	`43.3% <0%> (-0.11%)`	⬇️
src/objset.c	`84.82% <0%> (+0.22%)`	⬆️
hpcgap/lib/hpc/stdtasks.g	`64.96% <0%> (+0.25%)`	⬆️

fingolfin · 2018-04-28T22:16:51Z

doc/changes/changes49.xml

+(but not yet all: help with this is welcome). Some relevant pull requests:
+<List>
+<Item>
+ <!-- [#1165](https://github.com/gap-system/gap/pull/1165) -->


Perhaps these should be turned into actual hyperlinks? E.g. at the end of each entry, have something like (#1234, #1236) with both PR numbers hyperlinks.

Yes, I had actually a similar thought - good to see someone else expressing it too... Some places already got text like (For some technical details, +see <URL Text="#609">https://github.com/gap-system/gap/pull/609</URL>). - I am all for doing this for the rest. This will be especially helpful when the description is less than informative or sounds too similar to another entry.

olexandr-konovalov · 2018-05-01T23:08:14Z

Making PDF version currently produces a number of messages

! You can't use `macro parameter character #' in horizontal mode.
<argument> ##

because it trips over # in

<URL Text="#490">https://github.com/gap-system/gap/pull/490</URL>)

I've figured out that one can do

<URL><LinkText><Alt Only="LaTeX">\\</Alt>#484</LinkText><Link>https://github.com/gap-system/gap/pull/484</Link></URL>

and then hash appears in PDF, but from a new line. Not sure what to do except ignoring LaTeX warnings and not having hashes in the PDF version of the manual.

olexandr-konovalov · 2018-05-02T13:43:15Z

Thanks @fingolfin - a combination of

<!ENTITY Hash  "<Alt Only='LaTeX'>\#</Alt><Alt Not='LaTeX'>#</Alt>">

and

<URL><LinkText>&Hash;484</LinkText><Link>https://github.com/gap-system/gap/pull/484</Link></URL>

resolves this.

olexandr-konovalov · 2018-05-02T14:24:41Z

This seems to be ready for the reviewing, but may later require some updates related to #2431. Also, I will have to update URL elements to use &Hash; as shown above, but if anyone would like to loom at the text in the meantime, please go ahead!

fingolfin · 2018-05-02T15:32:38Z

doc/changes/changes49.xml

+<Item>
+In addition to supporting single argument lambda functions like 
+<C>a -> a+1</C>, &GAP; now supports lambdas with fewer or more than
+one argument, or even an arbitrary number. E.g. <C>{a,b} -> a+b</C>


I think "an arbitrary number" should be changed to "a variable number" (also in the Wiki) for clarity

fingolfin · 2018-05-02T15:33:19Z

doc/changes/changes49.xml

+<C>a -> a+1</C>, &GAP; now supports lambdas with fewer or more than
+one argument, or even an arbitrary number. E.g. <C>{a,b} -> a+b</C>
+is a shorthand for <C>function(a,b) return a+b; end</C>. For details,
+see <Ref BookName="ref" Sect="Function"/>. (For technical details,


Twice "For details", though once "technical"... Perhaps: "For details on how to use this, see REF. For technical details, ..." ?

fingolfin · 2018-05-02T15:34:12Z

doc/changes/changes49.xml

+<URL Text="#490">https://github.com/gap-system/gap/pull/490</URL>).
+</Item>
+<Item>
+Function calls, list accesses and records now can be nested. For example,


change "records" -> "records accesses"

fingolfin · 2018-05-02T15:43:48Z

doc/changes/changes49.xml

+<URL Text="TransGrp">http://www.math.colostate.edu/~hulpke/transgrp/</URL>.
+For backwards compatibility, these are required packages in &GAP; 4.9
+(i.e., &GAP; will not start without them). We plan to change this for
+&GAP; 4.10, once all packages which currently implicitly rely on these


Off-topic, but: Do we have an issue with milestone 4.10 tracking this? E.g. listing all packages that need to be updated; if we have that list, or else a request to create such a list, then notify package authors?

If not, we should perhaps create it, and link to it here?

Done in #2434

fingolfin · 2018-05-02T15:45:25Z

doc/changes/changes49.xml

+<Item>
+We removed our old home-grown big integer code, and instead always use the
+GMP based big integer code. This means that the GMP library now is a
+required dependency, not just an optional one.


Perhaps add:

Note that GAP has been using GMP big integer arithmetic for a long time by default, and we also have been bundling GMP with GAP. So this change mostly removed code that was never in use for most user.

fingolfin · 2018-05-02T15:55:57Z

doc/changes/changes49.xml

+computation, has been added for the redistribution.
+<P/>
+
+<Package>HAPprime</Package> package by Paul Smith is no longer redistributed


Add "The" at start of sentence. Also, why is it "XYZ package" here, but "package XYZ" above (different word order)?

fingolfin · 2018-05-02T15:56:51Z

doc/changes/changes49.xml

+
+<Package>HAPprime</Package> package by Paul Smith is no longer redistributed
+with &GAP;. Part of the code has been incorporated into the <Package>HAP</Package>
+package. <Package>HAPprime</Package> source code repository could be found at


Add "The" at start of sentence. And replace "could be" by "can still be". Perhaps also insert "containing the code of the last distributed version" somewhere?

fingolfin · 2018-05-02T15:57:10Z

doc/changes/changes49.xml

+<URL>https://github.com/gap-packages/happrime</URL>.
+<P/>
+
+Also, <Package>ParGAP</Package> package by Gene Cooperman 


again, insert "the" before the package name.

fingolfin · 2018-05-02T15:57:55Z

doc/changes/changes49.xml

+Also, <Package>ParGAP</Package> package by Gene Cooperman 
+is no longer redistributed with &GAP; (see
+<URL Text="this announcement">https://mail.gap-system.org/pipermail/gap/2018-March/001082.html </URL>). 
+<Package>ParGAP</Package> source code repository could be found at


could -> can; all the same remarks as for HAPPrime apply, though here one could write: "containing the code of the last distributed version, plus some first fixes needed for compatibility for GAP 4.9"?

We could also insert: "If somebody is interested in repairing this package and taking over its maintenance, so that it can be distributed again, please contact the GAP team." ?

fingolfin · 2018-05-02T15:58:21Z

doc/changes/changes49.xml

+<P/>
+
+Also, <Package>ParGAP</Package> package by Gene Cooperman 
+is no longer redistributed with &GAP; (see


perhaps insert "because it no longer can be compiled with GAP 4.9" before the "(see "

olexandr-konovalov · 2018-05-02T21:48:43Z

Thank you @fingolfin - pushed new version with updated URL format and your comments taken into account.

olexandr-konovalov · 2018-05-03T09:18:21Z

As for unresolved links (#2431), tempting to replace them by <C>..</C> today, make 4.9.1 release, and then resolve #2431 in due course, to not to cause any further delays.

fingolfin · 2018-05-04T13:41:44Z

doc/changes/changes49.xml

+(<URL><LinkText>&Hash;1991</LinkText><Link>https://github.com/gap-system/gap/pull/1991</Link></URL>)
+</Item>
+<Item>
+Fix <Ref BookName="ref" Oper="PositionProperty"/> with from &lt; 1


from is an argument, so perhaps <A>from</A>, or at least <C>from</C>

fingolfin · 2018-05-04T13:55:12Z

doc/changes/changes49.xml

+</Item>
+<Item>
+Fix <Ref BookName="ref" Oper="QuotientMod"/> documentation, and the integer
+implementation. This partially reverts changes made in 2013. The documentation


Instead of (or in addition to) saying 2013, let's say this was in version GAP 4.7.8, which I think is more helpful for most people.

olexandr-konovalov · 2018-05-04T15:38:59Z

Avoided unresolved links and implemented two most recent @fingolfin's suggestions - should be ready for merge.

fingolfin · 2018-06-15T12:43:47Z

Was backported in commit d4f7777

olexandr-konovalov added topic: documentation Issues and PRs related to documentation backport-to-4.9 labels Apr 27, 2018

olexandr-konovalov added this to the GAP 4.9.1 milestone Apr 27, 2018

fingolfin mentioned this pull request Apr 27, 2018

Weird random failure in testbugfix, on IsDocumentedWord( "d" ); #2415

Closed

olexandr-konovalov force-pushed the changes-4.9.1 branch from 2ac6b57 to 11b46ea Compare April 27, 2018 22:19

olexandr-konovalov mentioned this pull request Apr 28, 2018

GAP 4.9 syntax used, but PackageInfo.g claims 4.7 support gap-packages/polycyclic#27

Closed

fingolfin reviewed Apr 28, 2018

View reviewed changes

olexandr-konovalov force-pushed the changes-4.9.1 branch 2 times, most recently from be83fb0 to 4ad909d Compare May 1, 2018 22:33

olexandr-konovalov force-pushed the changes-4.9.1 branch from 4ad909d to 16d268b Compare May 2, 2018 14:21

olexandr-konovalov requested review from ChrisJefferson and fingolfin May 2, 2018 14:26

fingolfin reviewed May 2, 2018

View reviewed changes

olexandr-konovalov force-pushed the changes-4.9.1 branch from 16d268b to 53ee863 Compare May 2, 2018 21:44

olexandr-konovalov mentioned this pull request May 3, 2018

Release notes for GAP 4.9.1 #2152

Closed

fingolfin reviewed May 4, 2018

View reviewed changes

Overview of changes in GAP 4.9.1 release

88faa20

olexandr-konovalov force-pushed the changes-4.9.1 branch from 53ee863 to 88faa20 Compare May 4, 2018 14:51

fingolfin approved these changes May 4, 2018

View reviewed changes

fingolfin merged commit 0d17ed5 into gap-system:master May 4, 2018

olexandr-konovalov deleted the changes-4.9.1 branch May 4, 2018 22:19

fingolfin added the backport-to-4.9-DONE label Jun 15, 2018

olexandr-konovalov added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jun 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overview of changes in GAP 4.9.1 release #2418

Overview of changes in GAP 4.9.1 release #2418

olexandr-konovalov commented Apr 27, 2018 •

edited

Loading

codecov bot commented Apr 27, 2018 •

edited

Loading

fingolfin Apr 28, 2018

olexandr-konovalov Apr 28, 2018 •

edited

Loading

olexandr-konovalov commented May 1, 2018

olexandr-konovalov commented May 2, 2018

olexandr-konovalov commented May 2, 2018 •

edited

Loading

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

olexandr-konovalov May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

fingolfin May 2, 2018

olexandr-konovalov commented May 2, 2018

olexandr-konovalov commented May 3, 2018

fingolfin May 4, 2018

fingolfin May 4, 2018

olexandr-konovalov commented May 4, 2018

fingolfin commented Jun 15, 2018

Overview of changes in GAP 4.9.1 release #2418

Overview of changes in GAP 4.9.1 release #2418

Conversation

olexandr-konovalov commented Apr 27, 2018 • edited Loading

codecov bot commented Apr 27, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

olexandr-konovalov Apr 28, 2018 • edited Loading

Choose a reason for hiding this comment

olexandr-konovalov commented May 1, 2018

olexandr-konovalov commented May 2, 2018

olexandr-konovalov commented May 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olexandr-konovalov commented May 2, 2018

olexandr-konovalov commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olexandr-konovalov commented May 4, 2018

fingolfin commented Jun 15, 2018

olexandr-konovalov commented Apr 27, 2018 •

edited

Loading

codecov bot commented Apr 27, 2018 •

edited

Loading

olexandr-konovalov Apr 28, 2018 •

edited

Loading

olexandr-konovalov commented May 2, 2018 •

edited

Loading