Improve tracking of InstallMethod and DeclareOperation #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: enhancement
Codecov Report
@@ Coverage Diff @@
## master #2422 +/- ##
==========================================
+ Coverage 73.88% 73.89% +<.01%
==========================================
Files 484 484
Lines 245465 245477 +12
==========================================
+ Hits 181371 181383 +12
Misses 64094 64094
|
|
I don't have strong feelings about LGTM |
ThomasBreuer
approved these changes
May 1, 2018
fingolfin
force-pushed
the
mh/better-InstallMethod-tracking
branch
from
6721469 to
12ccbdd
Compare
|
@ThomasBreuer good point; I changed it to now store a triple |
fingolfin
force-pushed
the
mh/better-InstallMethod-tracking
branch
from
12ccbdd to
b767782
Compare
So far, we used `INPUT_LINENUMBER()` to record the location of an InstallMethod or DeclareOperation call. But in case such a call takes multiple lines, that points to the *last* line, while we would prefer if it pointed to the *first* line. To achieve that, we add a new global variable `READEVALCOMMAND_LINENUMBER` which is updated at the start of `ReadEvalCommand`.
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we used
INPUT_LINENUMBER()to record the location of anInstallMethodorDeclareOperationcall. But in case such a call takes multiple lines, that points to the last line, while we would prefer if it pointed to the first line. To achieve that, we add a new global variableREADEVALCOMMAND_LINENUMBERwhich is updated at the start ofReadEvalCommand.One may debate whether it might be better if
READEVALCOMMAND_LINENUMBERwas a global function which returns the desired result. If somebody has a good argument for that, I'll be happy to adapt the patch. The only reason I used a global variable is that it was the quickest way to implement this.