Improve tracking of InstallMethod and DeclareOperation #2422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we used
INPUT_LINENUMBER()
to record the location of anInstallMethod
orDeclareOperation
call. But in case such a call takes multiple lines, that points to the last line, while we would prefer if it pointed to the first line. To achieve that, we add a new global variableREADEVALCOMMAND_LINENUMBER
which is updated at the start ofReadEvalCommand
.One may debate whether it might be better if
READEVALCOMMAND_LINENUMBER
was a global function which returns the desired result. If somebody has a good argument for that, I'll be happy to adapt the patch. The only reason I used a global variable is that it was the quickest way to implement this.