More tests for group constructors; fix docs for Omega group constructor #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: documentation
fingolfin
force-pushed
the
mh/test-group-constructors
branch
from
59aec56 to
5aaaf0e
Compare
ChrisJefferson
approved these changes
May 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #2432 +/- ##
==========================================
+ Coverage 73.89% 73.96% +0.06%
==========================================
Files 484 484
Lines 245479 245479
==========================================
+ Hits 181392 181562 +170
+ Misses 64087 63917 -170
|
The documentation for `Omega` claimed that the returned group always has index in the corresponding special orthogonal group. But that's not true in characteristic 2, where they are equal.
fingolfin
force-pushed
the
mh/test-group-constructors
branch
from
5aaaf0e to
464b1fc
Compare
fingolfin
force-pushed
the
mh/test-group-constructors
branch
from
464b1fc to
db695df
Compare
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
Omegaclaimed that the returned group always has index in the corresponding special orthogonal group. But that's not true in characteristic 2, where they are equal.