Warning update #2508
Merged
Warning update #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to avoid a warning about jumping over these declarations with 'goto finish;'
ChrisJefferson
force-pushed
the
warning-update
branch
from
57ba5f5
to
fa73624
Compare
Merged
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
==========================================
+ Coverage 74.41% 74.41% +<.01%
==========================================
Files 481 481
Lines 244613 244613
==========================================
+ Hits 182033 182035 +2
+ Misses 62580 62578 -2
|
fingolfin
requested changes
Jun 4, 2018
| @@ -69,12 +77,9 @@ AC_DEFUN([AX_COMPILER_FLAGS_CFLAGS],[ | |||
| -Wall dnl | |||
| -Wextra dnl | |||
| -Wundef dnl | |||
| -Wnested-externs dnl | |||
There was a problem hiding this comment.
First thought this got remove, but apparently it was just moved to a C specific section (though we always use a C compiler anyway, don't we?!?)
| @@ -461,7 +463,7 @@ static UInt GetNumber(Int readDecimalPoint) | |||
| } | |||
|
|
|||
| // If the next thing is the start of the exponential notation, read it now. | |||
| UInt seenExp = 0; | |||
|
|
|||
There was a problem hiding this comment.
Ahh, nevermind, it's explained in the commit message.
ChrisJefferson
added
topic: kernel
release notes: not needed
fingolfin
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the list of warnings we use to the latest version, keeping our modifications.
I also disable -Wswitch-enum, as it doesn't let you use 'default' in a switch.
EDIT: There is one warning i needed to fix. This commit first had a big giant diff, now I have a much smaller one. While this does make this function slightly worse (i think), the warning is generally useful so I'd like to keep it.