Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib to extern (DO NOT MERGE) #2516

Closed
wants to merge 3 commits into from

Conversation

fingolfin
Copy link
Member

This adds zlib 1.2.11 to the GAP git repository, as well as build system modifications to make use of a system installed zlib, with a fallback to ours. I expect that PR #2509 will be rebased on this. As such, this PR likely should not be merged independently. But we can discuss this tomorrow.

@fingolfin fingolfin added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) topic: build system release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jun 5, 2018
@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #2516 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2516      +/-   ##
==========================================
- Coverage   74.41%    74.4%   -0.02%     
==========================================
  Files         481      479       -2     
  Lines      242658   237683    -4975     
==========================================
- Hits       180583   176845    -3738     
+ Misses      62075    60838    -1237
Impacted Files Coverage Δ
src/modules.h 33.33% <0%> (-66.67%) ⬇️
src/gvars.h 66.66% <0%> (-33.34%) ⬇️
src/fibhash.h 66.66% <0%> (-33.34%) ⬇️
src/gasman.h 73.07% <0%> (-20.03%) ⬇️
src/calls.h 76.59% <0%> (-19.15%) ⬇️
lib/files.gi 27.04% <0%> (-17.63%) ⬇️
src/hookintrprtr.h 87.5% <0%> (-12.5%) ⬇️
src/objects.h 88.37% <0%> (-11.63%) ⬇️
src/intobj.h 89.18% <0%> (-10.82%) ⬇️
src/range.h 90% <0%> (-10%) ⬇️
... and 86 more

@olexandr-konovalov olexandr-konovalov added the gapdays2018-spring Issues and PRs that arose at http://www.gapdays.de/gap-jupyter-days2018 label Jun 8, 2018
@ChrisJefferson
Copy link
Contributor

This is subsumed by #2509, so I think can be closed.

@fingolfin fingolfin deleted the mh/zlib branch October 28, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) gapdays2018-spring Issues and PRs that arose at http://www.gapdays.de/gap-jupyter-days2018 release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants