-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the Julia GC integration #2688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2688 +/- ##
==========================================
+ Coverage 75.75% 75.87% +0.12%
==========================================
Files 478 481 +3
Lines 241495 241314 -181
==========================================
+ Hits 182940 183094 +154
+ Misses 58555 58220 -335
|
Since those Julia changes are not yet quite stable, let's wait with merging this for now. For the status of the Julia side of things, see here: JuliaLang/julia#28368 |
Memo to @rbehrends and myself: we should also modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem likely to be ready for the "final" Julia GC extension interface (although that still hasn't been merged). For user convenience, it'd be nice to still get this into GAP 4.10. Since the code in here is disabled for non-Julia users, that should cause no issues.
This brings the implementation in line with the most recent API changes for the Julia GC extensions and cleans up some code.