-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: add libcurl for curlInterface; don't build Digraphs #2768
Conversation
bd20bca
to
348607e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2768 +/- ##
==========================================
+ Coverage 75.81% 75.81% +<.01%
==========================================
Files 481 481
Lines 241517 241517
==========================================
+ Hits 183105 183106 +1
+ Misses 58412 58411 -1
|
348607e
to
01a64df
Compare
Also, in 64-bit build, the test fail when it comes to loading digraphs: an
|
@james-d-mitchell I have temporary disabled Digraphs build here, to avoid P.S. And we already tried to revert that hack, and it worked for a while, until the problem reappeared: #2391 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I still hope to fix the issues with digraphs, float and semigroups (e.g. via PR #2759), let's be pragmatic and fix the broken build now and then work on a "better" fix afterwards.
The new curlInterface requires
libcurl4-openssl-dev
. For the 32-bit build one should addlibcurl4-openssl-dev:i386
.